Set to draft as a demo build shows some colour output but also ANSI codes leaking out:

before:https://buildbot.python.org/#/builders/301/builds/11808/steps/6/logs/stdio
after:https://buildbot.python.org/#/builders/301/builds/11810/steps/6/logs/stdio

I'm not convinced by this change. It makes my typical use case more painful: download logs and open them in a text editor (vim). There are now ANSI codes which make the logs harder to read :-(

Set to draft as a demo build shows some colour output but also ANSI codes leaking out:

At the beginning, there are nice colors. At the middle, raw ANSI codes are displayed which makes the output harder to read :-(

Also, if I download the logs and open them my text editor (vim), I also see the raw ANSI codes (not colors).

Yeah, it's not ready for merge, it's not meant to switch from colour to ANSI codes mid-way.

Also, if I download the logs and open them my text editor (vim), I also see the raw ANSI codes (not colors).

Hmm, even if we fix the switch, the codes would still be there when downloading logs viewing in a text editor.

This is also the case with GitHub Actions: compare therendered logs and theraw logs. But I think people rarely look at the raw logs. (I occasionally diff them, but the rendered colour is much more beneficial to me than the codes when diffing.)

If it's more important to keep raw logs more readable than rendered logs for Buildbots, then we can just close this.

btw, is there a way to download the full logs from a Buildbot run (that is, all of "configure", "compile", "test", and so on), rather than just for a single step (for example, just "test")?

If it's more important to keep raw logs more readable than rendered logs for Buildbots, then we can just close this.

The problem of buildbots is that the web site is very slow and buggy. Reading logs with an external tool is a workaround for that. It's also easier for me to navigate large logs (2 000 lines or more) with a fast text editor, rather than the slow web site.

btw, is there a way to download the full logs from a Buildbot run (that is, all of "configure", "compile", "test", and so on), rather than just for a single step (for example, just "test")?

I'm not aware of such feature, I always download logs of a single step such as "test".