Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Nov 23, 2017. It is now read-only.
/asyncioPublic archive

Fix for #404#460

Open
asvetlov wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromasvetlov-patch-1
Open

Fix for #404#460

asvetlov wants to merge1 commit intomasterfromasvetlov-patch-1

Conversation

asvetlov
Copy link

Don't pass ssl certivicate error to loop.call_exception_handler()
Handle ssl.CertificateError only because ssl.SSLError may be raised not only on connection establishment.

@1st1 please take a look

Don't pass ssl certivicate error to loop.call_exception_handler()Handle ssl.CertificateError only because ssl.SSLError may be raised not only on connection establishment.
@asvetlov
Copy link
Author

Fixes#404

Copy link
Member

@1st11st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Updating_FATAL_ERROR_IGNORE worries me: I don't think I understand all consequences of this PR. Could you please elaborate more?

@asvetlov
Copy link
Author

_FATAL_ERROR_IGNORE is a tuple of exceptions which doesn't generate noisyloop.call_exception_handler() if connection cannot be established (seehttps://github.com/python/asyncio/blob/master/asyncio/selector_events.py#L633) for usage example.
ssl.CertificateError goes to this category -- it could be raised only at connecting stage.
The exception still is thrown to outer code but not logged unless debug mode is disabled.

@1st1
Copy link
Member

Makes sense. Would you be able to write a unittest for this?

@1st1
Copy link
Member

1st1 commentedMar 2, 2017

@asvetlov If you want this in 3.6.1 you need to add a unittest and resubmit this PR to python/cpython today.

@AraHaan
Copy link

AraHaan commentedMar 2, 2017
edited
Loading

@1st1 ok, so 3.6.1 is going out after today? btw would it also include the latest version of zlib as well because it has updated a to version above 1.2.8 this year to fix bugs and stuff.

@1st1
Copy link
Member

1st1 commentedMar 2, 2017

@1st1 ok, so 3.6.1 is going out after today? btw would it also include the latest version of zlib as well because it has updated a to version above 1.2.8 this year to fix bugs and stuff.

Yes. Re zlib - not sure, please check on GH or bugs.python.org or python-dev mailing list.

@AraHaan
Copy link

AraHaan commentedMar 3, 2017
edited
Loading

hmm, from the looks onhttp://svn.python.org/projects/external/ I only see it having zlib v1.2.3 But I could have sworn python 3.6.0 was using 1.2.8. Will look at bugs.python.org or the python-dev irc channel.

@AraHaan
Copy link

@1st1 It looks like this repo was not marked asRead Only in it's settings to disable (I think it disables) the new issue / Pull Request buttons. Might want to do it explicitly in case someone does not read the readme in the redirect branch.

@decaz
Copy link

@asvetlov are you going to resubmit this PR to python/cpython ? I hope it's not abandoned.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@1st11st11st1 requested changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@asvetlov@1st1@AraHaan@decaz@brettcannon@the-knights-who-say-ni

[8]ページ先頭

©2009-2025 Movatter.jp