Commit99ebe37

committed

Raise DeprecationWarning when run_in_executor is called with a Handle

(Closes issue#334)

1 parentb0e7438 commit99ebe37Copy full SHA for 99ebe37

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -605,6 +605,9 @@ def run_in_executor(self, executor, func, *args):`
`605`	`605`	`ifisinstance(func,events.Handle):`
`606`	`606`	`assertnotargs`
`607`	`607`	`assertnotisinstance(func,events.TimerHandle)`
	`608`	`+warnings.warn(`
	`609`	`+"Passing Handle to loop.run_in_executor() is deprecated",`
	`610`	`+DeprecationWarning)`
`608`	`611`	`iffunc._cancelled:`
`609`	`612`	`f=self.create_future()`
`610`	`613`	`f.set_result(None)`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,8 @@ def cb():`
`358`	`358`	`h=asyncio.Handle(cb, (),self.loop)`
`359`	`359`	`h.cancel()`
`360`	`360`
`361`		`-f=self.loop.run_in_executor(None,h)`
	`361`	`+withself.assertWarnsRegex(DeprecationWarning,"Passing Handle"):`
	`362`	`+f=self.loop.run_in_executor(None,h)`
`362`	`363`	`self.assertIsInstance(f,asyncio.Future)`
`363`	`364`	`self.assertTrue(f.done())`
`364`	`365`	`self.assertIsNone(f.result())`
`@@ -373,12 +374,14 @@ def cb():`
`373`	`374`
`374`	`375`	`self.loop.set_default_executor(executor)`
`375`	`376`
`376`		`-res=self.loop.run_in_executor(None,h)`
	`377`	`+withself.assertWarnsRegex(DeprecationWarning,"Passing Handle"):`
	`378`	`+res=self.loop.run_in_executor(None,h)`
`377`	`379`	`self.assertIs(f,res)`
`378`	`380`
`379`	`381`	`executor=mock.Mock()`
`380`	`382`	`executor.submit.return_value=f`
`381`		`-res=self.loop.run_in_executor(executor,h)`
	`383`	`+withself.assertWarnsRegex(DeprecationWarning,"Passing Handle"):`
	`384`	`+res=self.loop.run_in_executor(executor,h)`
`382`	`385`	`self.assertIs(f,res)`
`383`	`386`	`self.assertTrue(executor.submit.called)`
`384`	`387`

Comments

(0)