- Notifications
You must be signed in to change notification settings - Fork176
Improve detection of multiple event loops being requested in a test#873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
seifertm wants to merge3 commits intopytest-dev:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecov-commenter commentedJul 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #873 +/- ##======================================= Coverage 92.08% 92.08% ======================================= Files 2 2 Lines 480 480 Branches 96 96 ======================================= Hits 442 442 Misses 23 23 Partials 15 15 ☔ View full report in Codecov by Sentry. |
ContributorAuthor
seifertm commentedJul 9, 2024
Blocked by#706 |
5 tasks
…ped loop is pulled in by an async autouse fixture in addition to an event loop with larger scope.Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
… of a test item.Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
bf6f5a7 tobae1d1eCompare…e test.Previously, the detection was limited to a function-scoped loop and a higher-scoped loop.Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
f492fd8 toa70577cCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Partially addresses#868