- Notifications
You must be signed in to change notification settings - Fork176
test that mark.asyncio scope is respected#770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
minrk wants to merge1 commit intopytest-dev:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
it is not, if there is a function-scoped fixture included
Contributor
seifertm commentedJul 13, 2024
Thanks for the example! I haven't looked at it in detail, yet, but it could be related to#868 . |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test case for tangential issue discovered trying toprovide an example use case for#706.
When a function-scoped async fixture is used,
@pytest.mark.asyncio(scope="module")on tests is ignored. Notably, when the function-scoped fixture is used inany test, thescope="module"is ignored. Sotest_module_looppasses if it is the only test, but if either of the other two tests are enabled,test_module_loopwill fail without modification.test_module_loop_function_fixturealways fails.Draft because this only adds a failing test. I don't think I have the expertise to actually fix the behavior, but hopefully the test case can help someone make sure it's fixed.