- Notifications
You must be signed in to change notification settings - Fork176
Add pyright type-checking#1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tjkuson commentedJul 24, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I'll close this for now, there's an issue with pyright and pre-commit CI:RobertCraigie/pyright-python#345 |
seifertm commentedJul 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Rather than running pyright in pre-commit, we can consider running it in a dedicated tox environment. This would give us the benefit of having a pyright check for the code base, while 90% of typing issues should still be caught by the mypy pre-commit hook. @tjkuson Do you think this approach would side-step the issue? |
codecov-commenter commentedJul 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1172 +/- ##==========================================+ Coverage 88.16% 88.88% +0.72%========================================== Files 2 2 Lines 397 405 +8 Branches 44 44 ==========================================+ Hits 350 360 +10 Misses 35 35+ Partials 12 10 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tjkuson commentedJul 30, 2025
@seifertm I've moved the pyright check from pre-commit to tox and re-opened the PR. |
seifertm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! This will help catch issues that are flagged by pyright, but not by mypy (even though we don't run pyright in a pre-commit hook).
6950774Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Hello, I was working with this plugin and encountered this issue.
I added pyright as a tox test matching the mypy hook.
This reveals one error involving
function.parentpossibly beingNone. I resolved this by adding an assertion, as that appears to be most consistent with the rest of the codebase.Closes#731