- Notifications
You must be signed in to change notification settings - Fork176
Replace event loops with asyncio.Runner#1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
seifertm merged 5 commits intopytest-dev:mainfromseifertm:replace-event-loops-with-asyncio-runnerJun 25, 2025
Merged
Replace event loops with asyncio.Runner#1152
seifertm merged 5 commits intopytest-dev:mainfromseifertm:replace-event-loops-with-asyncio-runnerJun 25, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Previously, pytest-asyncio used a combination of low-level asyncio functions to manage event loops. This patch replaces the low-level functions with the use of asyncio.Runner. The runner takes care of cancelling remaining tasks at the end of its scope, avoiding errors about pending tasks. This also fixes an issue that caused RuntimeErrors in abanoned tasks that called functions which depend on a running loop.Moreover, the use of asyncio.Runner allows backporting the propagation of contextvars from fixtures to tests to Python 3.9 and Python 3.10.
codecov-commenter commentedJun 24, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1152 +/- ##==========================================- Coverage 89.40% 89.01% -0.39%========================================== Files 2 2 Lines 434 428 -6 Branches 51 51 ==========================================- Hits 388 381 -7- Misses 31 33 +2+ Partials 15 14 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged via the queue intopytest-dev:main with commitJun 25, 2025
f9c5d67 18 of 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, pytest-asyncio used a combination of low-level asyncio functions to manage event loops. This patch replaces the low-level functions with the use of asyncio.Runner.
The runner takes care of cancelling remaining tasks at the end of its scope, avoiding errors about pending tasks. This also fixes an issue that caused RuntimeErrors in abanoned tasks that called functions which depend on a running loop.
Moreover, the use of asyncio.Runner and its backport allows backporting the propagation of contextvars from fixtures to tests to Python 3.9 and Python 3.10.
Supersedes#309
Closes#127
Closes#200
Closes#878
Partially addresses#1032