Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Release 9.0.1#13938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
github-actions wants to merge2 commits into9.0.xfromrelease-9.0.1
Closed

Release 9.0.1#13938

github-actions wants to merge2 commits into9.0.xfromrelease-9.0.1

Conversation

@github-actions
Copy link
Contributor

Created by theprepare release pr workflow.

Once all builds pass and it has beenapproved by one or more maintainers, start thedeploy workflow, using these parameters:

  • Use workflow from:release-9.0.1.
  • Release version:9.0.1.

Or execute on the command line:

gh workflow run deploy.yml -r release-9.0.1 -f version=9.0.1

After the workflow has been approved by a core maintainer, the package will be uploaded to PyPI automatically.

$ pytest --version
pytest 9.0.0
pytest 9.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

❤️

@nicoddemusnicoddemus marked this pull request as ready for reviewNovember 11, 2025 22:33
? - -
+ '4': 4,
}
FAILED test_verbosity_example.py::test_long_text_fail - AssertionError: assert 'hello world' in 'Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet Lorem ips... sit amet Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems like these changes should have gone into the 9.0.0 release... 🤔

@nicoddemus
Copy link
Member

nicoddemus commentedNov 11, 2025
edited
Loading

pre-commit is failing with:

hook `pylint` has unsupported language `system`

I cannot reproduce this locally. Strange,language: system is something supported by pre-commit itself (pylint is actually a local hook and only executed manually).

I noticed it is building with an image released just today, might be related:

image ghcr.io/pre-commit-ci/runner-image:2025-11-11-0856608

Perhaps@asottile can chime in?

EDIT: I see this in thepre-commit changelog:

- Add `language: unsupported` / `language: unsupported_script` as aliases  for `language: system` / `language: script` (which will eventually be  deprecated).    - #3577 PR by @asottile.

@nicoddemus
Copy link
Member

nicoddemus commentedNov 11, 2025
edited
Loading

Pushed the fix for pre-commit inafce953. I will cherry-pick this back intomain (EDIT:#13939).

@asottile
Copy link
Member

huh that's a weird one. I guess I used the stricter parser in pre-commit ci by mistake

you'll probably want to useminimum_pre_commit_version to force the upgrade if using the new language name. I'll fix ci separately oops

nicoddemus reacted with thumbs up emoji

nicoddemus added a commit to nicoddemus/pytest that referenced this pull requestNov 12, 2025
Inpytest-dev#13939 we are using the new `language: unsupported` setting, which was introduced in pre-commit 4.4.0.Configure minimum pre-commit version to ensure the installed pre-commit supports it (pytest-dev#13938 (comment)).
@nicoddemus
Copy link
Member

nicoddemus commentedNov 12, 2025
edited
Loading

you'll probably want to use minimum_pre_commit_version to force the upgrade if using the new language name.

Thanks, done:#13941

@asottile
Copy link
Member

ok I've fixed pre-commit ci to notearly approach the deprecation 😆 small oversightpre-commit-ci/runner-image#316

nicoddemus reacted with heart emoji

@nicoddemus
Copy link
Member

Waiting on a second approval before proceeding with the release. 👍

E assert [0, 0, 0, 0, 0, 0, ...] == [0, 0, 0, 0, 0, 0, ...]
E
E At index 100 diff: 1 != 2
E Use -v to get more diff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This seems bad, any idea why it no longer truncates?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note: better to see this comment in the diff itself to understand...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems related to the changes in how we handle theCI environment variable... will investigate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suspect this will fix it:#13950.

nicoddemus added a commit to nicoddemus/pytest that referenced this pull requestNov 12, 2025
pytest auto-detects and uses more verbose output when running in CI.Change tox:regendoc to remove those environment variables, because we do not want extra verbose output in the user documentation.Seepytest-dev#13938 (comment).
nicoddemus added a commit that referenced this pull requestNov 12, 2025
pytest auto-detects and uses more verbose output when running in CI.Change tox:regendoc to remove those environment variables, because we do not want extra verbose output in the user documentation.See#13938 (comment).
patchbackbot pushed a commit that referenced this pull requestNov 12, 2025
pytest auto-detects and uses more verbose output when running in CI.Change tox:regendoc to remove those environment variables, because we do not want extra verbose output in the user documentation.See#13938 (comment).(cherry picked from commit82e9b97)
nicoddemus added a commit that referenced this pull requestNov 12, 2025
pytest auto-detects and uses more verbose output when running in CI.Change tox:regendoc to remove those environment variables, because we do not want extra verbose output in the user documentation.See#13938 (comment).(cherry picked from commit82e9b97)Co-authored-by: Bruno Oliveira <bruno@pytest.org>
@nicoddemus
Copy link
Member

Attempting this again after#13950.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicoddemusnicoddemusnicoddemus approved these changes

@bluetechbluetechbluetech left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nicoddemus@asottile@bluetech@pytestbot

[8]ページ先頭

©2009-2025 Movatter.jp