- Notifications
You must be signed in to change notification settings - Fork1.5k
Added Example(learning github)#2325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
for more information, seehttps://pre-commit.ci
| <title>Shiny Sound</title> | ||
| <!-- Recommended meta tags --> | ||
| <meta charset="UTF-8" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FYI /> has no meaning in HTML, it has meanings inXHTML andXML (orJSX) but not inHTML so you never need the self closing tag becausevoid elements never need that.
I know this is common misconception out there, I just wanted to point that out since the purpose of this PR is to learn 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I copied the code from pyscript.com why is it not changed over there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've just created a new project in there and this is what I see:
we have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
When CI fixes something (in this case it'sprettier) you shouldgit pull from this branch to update your local version with those fixes back/applied.
There is a major comment around where tests should go and a "nitpick" around the fact something is not really needed.
I am adding this review as part of the "learning" process, so that this PR cannot move forward until comments or other things are either agreed or approved as change.
FYI to rebase this branch you can follow command line instruction or To configure upstream:https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/configuring-a-remote-repository-for-a-fork |
Uh oh!
There was an error while loading.Please reload this page.
Description
Changes
Checklist
make buildworks locally.