- Notifications
You must be signed in to change notification settings - Fork1.5k
Fix #2246 - Override builtins.input to avoid duplicating it#2254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Published as |
JoshuaLowe1002 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for getting this up so quickly!
796373c
intopyscript:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Description
This MRfixes#2246 by overriding the
builtins.input
apparently needed to avoid duplicated text on constrained terminal width where apparentlysetStdin
is not enough and an extra override is needed for the builtins as we used to do in classic.Thanks@JoshuaLowe1002 for the hint around it, this has been manually successfully tested too.
Changes
builtins.input
when the terminal runs in aworkercode.interact()
aroundChecklist
make build
works locally.