Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix #2246 - Override builtins.input to avoid duplicating it#2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
WebReflection merged 1 commit intopyscript:mainfromWebReflection:issue-2246
Nov 25, 2024

Conversation

WebReflection
Copy link
Contributor

@WebReflectionWebReflection commentedNov 25, 2024
edited
Loading

Description

This MRfixes#2246 by overriding thebuiltins.input apparently needed to avoid duplicated text on constrained terminal width where apparentlysetStdin is not enough and an extra override is needed for the builtins as we used to do in classic.

Thanks@JoshuaLowe1002 for the hint around it, this has been manually successfully tested too.

Changes

  • overridebuiltins.input when the terminal runs in aworker
  • test everything is fine with orwithoutcode.interact() around

Checklist

  • I have checkedmake build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection
Copy link
ContributorAuthor

Published ashttps://cdn.jsdelivr.net/npm/@pyscript/core@0.6.20/dist/core.js to allow early tests before release.

Copy link
Member

@JoshuaLowe1002JoshuaLowe1002 left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for getting this up so quickly!:shipit:

@WebReflectionWebReflection merged commit796373c intopyscript:mainNov 25, 2024
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaLowe1002JoshuaLowe1002JoshuaLowe1002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2024.10.2] Terminal rendering issue with long text when using input()
2 participants
@WebReflection@JoshuaLowe1002

[8]ページ先頭

©2009-2025 Movatter.jp