Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.3k
Add optional Distribution parameter to walk_revctrl file finder#5056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
RonnyPfannschmidt wants to merge1 commit intopypa:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+148 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… pointsFile finder entry points for SCM-based files can now optionally receivethe Distribution object to make more informed decisions about which filesto include. This maintains full backward compatibility with existingentry points that only accept dirname.Changes:- Add optional distribution parameter to walk_revctrl function- Create _call_finder_with_distribution_support helper function with signature inspection to detect entry point capabilities- Update manifest_maker.add_defaults() to pass distribution object- Add comprehensive unit tests covering all scenarios including backward compatibility and error handling🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i made a first draft using claude - the tests need some simplification for the unit part and im looking for suggestions on a integration test thats not excessive
File finder entry points for SCM-based files can now optionally receive the Distribution object to make more informed decisions about which files to include. This maintains full backward compatibility with existing entry points that only accept dirname.
Changes:
🤖 Generated withClaude Code
Summary of changes
Closes
Pull Request Checklist
newsfragments/.(Seedocumentation for details)