Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Ignore newlines when processing keywords/platforms#4888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
frenzymadness wants to merge1 commit intopypa:main
base:main
Choose a base branch
Loading
fromfrenzymadness:multiline_keywords

Conversation

@frenzymadness
Copy link
Contributor

Summary of changes

Newlines inkeywords orplatforms can break
the produced metadata in PKG-INFO or METADATA files.

Fixes:#4887

Pull Request Checklist

  • Changes have tests
  • News fragment added in [newsfragments/].

Newlines in `keywords` or `platforms` can breakthe produced metadata in PKG-INFO or METADATA files.Fixes:pypa#4887
@abravalheri
Copy link
Contributor

Thank you very much@frenzymadness for having a look on this issue and proposing a solution.

I think we have 2 options according tohttps://setuptools.pypa.io/en/latest/development/developer-guide.html#code-conventions-and-other-practices (see description about modifying files in the_distutils folder):

  1. Contribute this change to thepypa/distutils repository (requires changing the test cases to another file that exists in thepypa/distutils repository).
  2. Attempt to implement a different change outside of the_distutils folder.

In the case we go for a change in thepypa/setuptools repository, I believe that the best here is to comply with the documented behaviour and raise an error when\n is used (maintainers ofpypa/distutils might have a different opinion).

@frenzymadness
Copy link
ContributorAuthor

You are right, sorry. Let me take this to distutils and see what they think about this change there.

@frenzymadnessfrenzymadness marked this pull request as draftMarch 19, 2025 09:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] multilinekeywords breaks metadata file

2 participants

@frenzymadness@abravalheri

[8]ページ先頭

©2009-2025 Movatter.jp