Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Enforce ruff/refurb rules (FURB)#4386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaraco merged 12 commits intopypa:mainfromDimitriPapadopoulos:FURB
May 31, 2025
Merged

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulosDimitriPapadopoulos commentedMay 23, 2024•
edited
Loading

Summary of changes

Follow-up of#4172.

Pull Request Checklist

Avasam reacted with thumbs up emoji
@AvasamAvasam mentioned this pull requestJun 17, 2024
2 tasks
@DimitriPapadopoulosDimitriPapadopoulos marked this pull request as ready for reviewJune 28, 2024 17:40
@DimitriPapadopoulosDimitriPapadopoulos marked this pull request as draftJune 28, 2024 17:42
@DimitriPapadopoulosDimitriPapadopoulos marked this pull request as ready for reviewJune 28, 2024 18:08
@DimitriPapadopoulosDimitriPapadopoulos changed the titleEnforce ruff/refurb rulesEnforce ruff/refurb rules (FURB)Jun 28, 2024
@Avasam
Copy link
Contributor

Looks like you're missing imports foroperator

@DimitriPapadopoulos
Copy link
ContributorAuthor

I think I mistakenly removed theimports while rebasing. Should be fixed now.

Avasam reacted with thumbs up emoji

@DimitriPapadopoulosDimitriPapadopoulos changed the titleEnforce more rules: ruff/refurb (FURB) and ruff/flake8-comprehensions (C4)Enforce ruff/refurb rules (FURB)Jan 1, 2025
@Avasam
Copy link
Contributor

@DimitriPapadopoulos I think you're missing aruff.toml change addingFURB

@Avasam
Copy link
Contributor

Now that this is back to being a simpler PR.@abravalheri /@jaraco refurb would also have been one of my suggestions with improvements in readability and simplifications.

@DimitriPapadopoulos
Copy link
ContributorAuthor

Rebased.

@DimitriPapadopoulos
Copy link
ContributorAuthor

DimitriPapadopoulosand others added10 commitsMay 23, 2025 17:05
FURB118 Use `operator.itemgetter(0)` instead of defining a lambda
FURB142 Use of `set.add()` in a for loop
FURB167 Use of regular expression alias `re.I`FURB167 Use of regular expression alias `re.M`FURB167 Use of regular expression alias `re.S`FURB167 Use of regular expression alias `re.X`
FURB188 Prefer `removesuffix` over conditionally replacing with slice.
FURB192 Prefer `max` over `sorted()` to compute the maximum value in a sequence
Co-authored-by: Avasam <samuel.06@hotmail.com>
DimitriPapadopoulosand others added2 commitsMay 25, 2025 10:49
Co-authored-by: Avasam <samuel.06@hotmail.com>
@jaracojaraco merged commitb8f8bcc intopypa:mainMay 31, 2025
18 of 20 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@AvasamAvasamAvasam left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DimitriPapadopoulos@Avasam@jaraco
[8]ページ先頭
©2009-2025 Movatter.jp