Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
Fix local file sub-dependencies not being recorded in lockfile#6498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
matteius wants to merge1 commit intomainChoose a base branch fromfix/local-subdep-lockfile-6119
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When a package (A) installed from a local path depends on anotherpackage (B) also installed from a local path, the sub-dependency (B)was not being properly recorded in Pipfile.lock. The lockfile entryfor B would be empty ({}) instead of containing the file/path info.This fix:- Differentiates between local directories (use 'path') and archive files (use 'file') for file:// URLs- Converts file:// URLs to relative paths for local directories- Removes version and index entries for file/path dependencies- Preserves the editable flag if setFixes#6119Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes#6119
Problem
When a package (A) installed from a local path depends on another package (B) also installed from a local path, the sub-dependency (B) was not being properly recorded in
Pipfile.lock. The lockfile entry for B would be empty ({}) instead of containing the file/path information.Expected Result:
Actual Result (before fix):
Root Cause
The
format_requirement_for_lockfile()function inpipenv/utils/locking.pywas settingentry["file"] = req.link.urlfor all file:// URLs. However:path(with a relative path) instead offile(with a URL)Solution
This fix:
path) and archive files (usefile) for file:// URLs usingreq.link.is_existing_dir()ensure_path_is_relative()versionandindexentries for file/path dependencieseditableflag if set on the requirementTesting
To test this fix, you can use the reproduction repository from the issue:
Pull Request opened byAugment Code with guidance from the PR author