Description

Still tracking exactly how this is being triggered, but wanted to report early just in case.

Inconsistently gettingValueError('ZIP does not support timestamps before 1980') in CI when installing requirements viagit+https for packages from GitHub.

I see the new zip functionality was introduced via#9689. Stack trace points tozf.write in_create_standalone_pip function.

Haven't been able to trigger locally in pip 21.1 yet, only seeing in CI, so wondering if i'm having some kind of network issue.

Either way, we might want to consider settingstrict_timestamps=False when using ZipFile for this:
https://docs.python.org/3/library/zipfile.html#zipfile-objects

Expected behavior

Correctly install requirement from GitHub.

pip version

21.1

Python version

3.9.2

OS

python:3.9.2-buster Docker container

How to Reproduce

Still trying to nail down a consistent method to reproduce. I suspect something in my CI is contributing to the issue. But exception is triggered while trying to install viagit+https requirement.

Output

No response

Code of Conduct

• I agree to follow thePSF Code of Conduct.