- Notifications
You must be signed in to change notification settings - Fork3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Drop support for EOL Python 3.4#6685
Conversation
@hugovk Thanks for the PR! In line with@cjerdonek's suggestion, could you drop all the additional changes (references to 3.4, version based checks etc) and file them as a separate PR? That way this PR would just be dropping Py3.4 from classifiers, requires error messages etc. |
Thanks for the reviews, updated! Please let me know if I missed something. |
Question: if someone happens to be running this pip version using Python 3.4, what should happen? Will it fail? If not, should it log a warning? |
First, But if someone does end up with this PR's changes on 3.4, it'll still work as no functional changes have been made. It may fail with the next PR, and will fail at some point in the future as code is modernised and newer features are used. Would you like an explicit failure message for unsupported versions (<=2.6, 3.0-3.4)? Although care would have to be taken to make sure the file showing the error is still actually compatible with those versions, and it should be tested to be sure it still works in the long term. What has been the approach for earlier removals? |
No point in doing this IMO. FWIW, modern versions of pip will refuse to install this version on 3.4 anyway. Once you start modifying the distribution, we're not liable for it. 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for doing this.
I'd argue that
Lines 352 to 355 inca017ca
| @pytest.fixture | |
| defdeprecated_python(): | |
| """Used to indicate whether pip deprecated this python version""" | |
| returnsys.version_info[:2]in [(3,4), (2,7)] |
deprecated call removal but it's ok if it's included in a future PR.Is there anything else I can do for this PR? It'd be nice to get it in this week's pip 19.2, in line with the deprecation message. Thank you! |
Yep yep. This is definitely on my TODO list for the release. Based on a cursory pass earlier, this seemed good to me. Plus, two folks have already approved it so I'm happy to merge this anyway, based on trust on the contributor + fellow maintainers. 🌈 |
Thanks for the PR@hugovk! Thanks for taking the time to look at this@xavfernandez@cjerdonek@chrahunt! :D |
Python 3.4 was EOL on 2019-03-16 and deprecated in#6123 and pip 19.0.
The deprecation warning reads:
pip 19.2 is coming soon (#6630) so drop support for Python 3.4.