- Notifications
You must be signed in to change notification settings - Fork301
Fix Minibatch alignment in Bayesian Neural Network example#689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Fix Minibatch alignment in Bayesian Neural Network example#689
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered byReviewNB |
Deepakchowdavarapu commentedAug 3, 2024
@yoshida-chem@twiecki please review waiting for your response |
twiecki commentedAug 3, 2024
Thanks@Deepakchowdavarapu! You need to run pre-commit locally so that the myst file is generated. |
Deepakchowdavarapu commentedAug 4, 2024
@twiecki ok sure can you please assign this issue to me !!! |
twiecki commentedAug 4, 2024
There's no issue, on this PR you'd need to run |
Deepakchowdavarapu commentedAug 15, 2024
pre-commit.ci autofix |
twiecki commentedAug 15, 2024
We might not have set that up here, but we should. Is pre-commit giving you problems? |
Deepakchowdavarapu commentedAug 15, 2024
I will run it locally and raise a new PR soon. |

Uh oh!
There was an error while loading.Please reload this page.
Fix Minibatch Alignment in Bayesian Neural Network Example
Issue
Fixes#654.
Description
This PR addresses the issue where
Minibatchvariables forX_trainandY_trainwere created separately, causing potential misalignment in slices and thus random pairing ofXwith unrelatedy.Changes Made
MinibatchforX_trainandY_traintogether, ensuring identical slices.ann_inputandann_outputusing the unifiedMinibatchvariables.construct_nnfunction.Impact
This change ensures that the model training process is more robust and prevents issues related to incorrect data alignment in minibatches.
Helpful links
📚 Documentation preview 📚:https://pymc-examples--689.org.readthedocs.build/en/689/