Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Minibatch alignment in Bayesian Neural Network example#689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Deepakchowdavarapu wants to merge1 commit intopymc-devs:main
base:main
Choose a base branch
Loading
fromDeepakchowdavarapu:fix-minibatch-issue

Conversation

@Deepakchowdavarapu
Copy link
Contributor

@DeepakchowdavarapuDeepakchowdavarapu commentedAug 2, 2024
edited by github-actionsbot
Loading

Fix Minibatch Alignment in Bayesian Neural Network Example

Issue

Fixes#654.

Description

This PR addresses the issue whereMinibatch variables forX_train andY_train were created separately, causing potential misalignment in slices and thus random pairing ofX with unrelatedy.

Changes Made

  • Updated the code to create a singleMinibatch forX_train andY_train together, ensuring identical slices.
  • Modified the construction ofann_input andann_output using the unifiedMinibatch variables.
  • Removed redundant parameters from theconstruct_nn function.
  • Confirmed model architecture and initialization remain consistent.

Impact

This change ensures that the model training process is more robust and prevents issues related to incorrect data alignment in minibatches.

Helpful links


📚 Documentation preview 📚:https://pymc-examples--689.org.readthedocs.build/en/689/

@review-notebook-app
Copy link

Check out this pull request on ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered byReviewNB

@Deepakchowdavarapu
Copy link
ContributorAuthor

@yoshida-chem@twiecki please review waiting for your response

@twiecki
Copy link
Member

Thanks@Deepakchowdavarapu! You need to run pre-commit locally so that the myst file is generated.

@Deepakchowdavarapu
Copy link
ContributorAuthor

@twiecki ok sure can you please assign this issue to me !!!

@twiecki
Copy link
Member

There's no issue, on this PR you'd need to runpre-commit run --all-files and then commit and push.

@Deepakchowdavarapu
Copy link
ContributorAuthor

pre-commit.ci autofix

@twiecki
Copy link
Member

We might not have set that up here, but we should. Is pre-commit giving you problems?

@Deepakchowdavarapu
Copy link
ContributorAuthor

I will run it locally and raise a new PR soon.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug in "Variational Inference: Bayesian Neural Networks" notebook

2 participants

@Deepakchowdavarapu@twiecki

[8]ページ先頭

©2009-2025 Movatter.jp