NotificationsYou must be signed in to change notification settings
Fork2.2k
Star9.4k

Update PyTensor dependency (drop numpy <2.0, and Python 3.10.)#7910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ricardoV94 merged 7 commits intopymc-devs:mainfromricardoV94:bump_pytensor_dep

Oct 16, 2025

Merged

Update PyTensor dependency (drop numpy <2.0, and Python 3.10.)#7910

ricardoV94 merged 7 commits intopymc-devs:mainfromricardoV94:bump_pytensor_dep

Oct 16, 2025

Conversation

Copy link

Member

ricardoV94 commentedSep 23, 2025•
edited
Loading

Some major import changes in the latest release

📚 Documentation preview 📚:https://pymc--7910.org.readthedocs.build/en/7910/

ricardoV94 added release pytensor majorInclude in major changes release notes section labels

Sep 23, 2025

jessegrabowski mentioned this pull request

Oct 4, 2025

Implement unconstraining transform for LKJCorr#7380

Open

10 tasks

ricardoV94 changed the title~~Update pytensor dependency~~Update PyTensor dependency

Oct 9, 2025

ricardoV94 force-pushed thebump_pytensor_dep branch fromc040c2b tobbfec83Compare

October 9, 2025 09:59

ricardoV94 marked this pull request as ready for review

October 9, 2025 09:59

ricardoV94 force-pushed thebump_pytensor_dep branch frombbfec83 to164ae58Compare

October 12, 2025 21:15

Copy link

MemberAuthor

ricardoV94 commentedOct 13, 2025

ugh loads of broken stuff

ricardoV94 force-pushed thebump_pytensor_dep branch from164ae58 tod532c45Compare

October 13, 2025 16:35

Copy link

MemberAuthor

ricardoV94 commentedOct 13, 2025

Failures had to do with functions that guessed the inputs for the user. The order changed since the last release and now gradients / forward were not aligned.

This was not a great idea to begin with, so I now raise anytime such method is called in a way that the input order is ambiguous.

Deterministic make_shared_replacements

e552245

ricardoV94 force-pushed thebump_pytensor_dep branch 3 times, most recently from4caaaca to3ddceccCompare

October 13, 2025 18:16

Copy link

MemberAuthor

ricardoV94 commentedOct 13, 2025

CI broken bypymc-devs/pytensor#1660 which means we'll need another release (which is also a major release as it drops old numpy / python) :)

Copy link

MemberAuthor

ricardoV94 commentedOct 14, 2025

getting close.@maresb @lucianopaz any luck with the windows blas issue on conda?

importorskip tests on optional dependencies

931f89f

ricardoV94 force-pushed thebump_pytensor_dep branch 3 times, most recently from04d3c35 to6f626faCompare

October 14, 2025 12:55

ricardoV94 changed the title~~Update PyTensor dependency~~Update PyTensor dependency (any functions that inferred inputs of the graph fail if there is more than one input, includingModel.compile_fn)

Oct 15, 2025

Copy link

MemberAuthor

ricardoV94 commentedOct 15, 2025

The verbose PR title is just to remind to add a note in the release notes

ricardoV94 changed the title~~Update PyTensor dependency (any functions that inferred inputs of the graph fail if there is more than one input, includingModel.compile_fn)~~Update PyTensor dependency (drop numpy <2.0, and Python 3.10. any functions that inferred inputs of the graph fail if there is more than one input, includingModel.compile_fn)

Oct 15, 2025

ricardoV94 force-pushed thebump_pytensor_dep branch 2 times, most recently from45b4034 to787179bCompare

October 15, 2025 09:00

Copy link

MemberAuthor

ricardoV94 commentedOct 15, 2025

I'm not testing on Windows because the release is held at conda-forge. I'll open an issue to revert the relevant commit onceconda-forge/pytensor-suite-feedstock#177 is fixed

ricardoV94 force-pushed thebump_pytensor_dep branch from787179b to33dcd38Compare

October 15, 2025 09:05

ricardoV94and others added2 commits

October 15, 2025 11:14

Shouldn't have to set PyTensor march flag

f0e7002

Update PyTensor dependency

056351a

Drops support for Python 3.10 and Numpy<2.0Co-authored-by: Jesse Grabowski <48652735+jessegrabowski@users.noreply.github.com>

ricardoV94 force-pushed thebump_pytensor_dep branch 2 times, most recently frombe479e8 to9d1f69fCompare

October 15, 2025 09:17

ricardoV94 added3 commits

October 15, 2025 11:19

More general type-hints

9efc102

Do not guess order of inputs for users

11c6f1d

Seed flaky JAX test

3ee50ac

ricardoV94 force-pushed thebump_pytensor_dep branch from9d1f69f to70a0df8Compare

October 15, 2025 09:21

Copy link

Contributor

maresb commentedOct 15, 2025

Ya, sorry, I'm working on it, but not sure yet what the problem is. Will try to follow Luciano's advice

Copy link

codecovbot commentedOct 15, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is88.67925% with6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.47%. Comparing base (6993a2f) to head (70a0df8).

Files with missing lines	Patch %	Lines
pymc/pytensorf.py	54.54%	5 Missing⚠️
pymc/model/core.py	91.66%	1 Missing⚠️

Additional details and impacted files

@@            Coverage Diff             @@##             main    #7910      +/-   ##==========================================- Coverage   91.63%   91.47%   -0.16%==========================================  Files         116      116                Lines       18882    18904      +22     ==========================================- Hits        17302    17292      -10- Misses       1580     1612      +32

Files with missing lines	Coverage Δ
pymc/distributions/custom.py	`95.45% <100.00%> (ø)`
pymc/distributions/shape_utils.py	`91.87% <100.00%> (ø)`
pymc/distributions/timeseries.py	`94.62% <100.00%> (+0.01%)`	⬆️
pymc/distributions/transforms.py	`100.00% <100.00%> (ø)`
pymc/initial_point.py	`99.20% <100.00%> (+<0.01%)`	⬆️
pymc/logprob/basic.py	`100.00% <100.00%> (ø)`
pymc/logprob/mixture.py	`95.72% <100.00%> (+0.01%)`	⬆️
pymc/logprob/rewriting.py	`100.00% <100.00%> (ø)`
pymc/logprob/tensor.py	`94.26% <100.00%> (ø)`
pymc/logprob/utils.py	`90.07% <100.00%> (+0.07%)`	⬆️
... and8 more

... and2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Contributor

maresb commentedOct 15, 2025

Ya, sorry, I'm working on it, but not sure yet what the problem is. Will try to follow Luciano's advice

Solved! 🎉

ricardoV94 force-pushed thebump_pytensor_dep branch from70a0df8 to3ee50acCompare

October 15, 2025 21:28

Copy link

MemberAuthor

ricardoV94 commentedOct 15, 2025

reverted the commit so we test on windows as usual

ricardoV94 requested review fromArmavica andjessegrabowski

October 15, 2025 21:29

Copy link

MemberAuthor

ricardoV94 commentedOct 15, 2025

Uhuh tests are passing

lucianopaz approved these changes

Oct 16, 2025

View reviewed changes

Copy link

Member

lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think the changes look OK, but maybe someone else should have a look too.

Armavica approved these changes

Oct 16, 2025

View reviewed changes

tests/sampling/test_jax.pyShow resolvedHide resolved

ricardoV94 merged commitf80e896 intopymc-devs:main

Oct 16, 2025

26 checks passed

ricardoV94 deleted the bump_pytensor_dep branch

October 16, 2025 19:47

ricardoV94 changed the title~~Update PyTensor dependency (drop numpy <2.0, and Python 3.10. any functions that inferred inputs of the graph fail if there is more than one input, includingModel.compile_fn)~~Update PyTensor dependency (drop numpy <2.0, and Python 3.10.)

Oct 16, 2025

Copy link

Contributor