Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Replaced "log-likelihood" with "distribution" in for all the classes where distributions is more appropriate rather than log-likelihood.#7573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
twiecki merged 8 commits intopymc-devs:mainfromtanishy7777:main
Mar 14, 2025

Conversation

@tanishy7777
Copy link
Contributor

@tanishy7777tanishy7777 commentedNov 13, 2024•
edited
Loading

Replaced "log-likelihood" with "distribution" in for all the classes where distributions is more appropriate rather than log-likelihood.

Description

Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance and covariance.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚:https://pymc--7573.org.readthedocs.build/en/7573/

Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including cdf, mean, and random methods.
@welcome
Copy link

welcomebot commentedNov 13, 2024

Thank You Banner]
💖 Thanks for opening this pull request! 💖 ThePyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read ourContributing Guidelines and filled in our pull request template to the best of your ability.

@ricardoV94
Copy link
Member

Hi@tanishy7777 the idea is to change all the cases where this happened, not just MvNormal

Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance, covariance.
@tanishy7777
Copy link
ContributorAuthor

I've implemented the changes as per your suggestions in the latest commit. Apologies for the delayed response my end-semester exams were going on.@ricardoV94

ricardoV94 reacted with thumbs up emoji

@ricardoV94
Copy link
Member

Does this happen only in multivariate.py?

Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance, covariance, etc.
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance, covariance.
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood including log-cdf, log-pdf.
@tanishy7777
Copy link
ContributorAuthor

tanishy7777 commentedNov 27, 2024•
edited
Loading

Oh ok, will make the necessary changes. I think only the pymc/distributions folder has the files where the changes need to be made right?
Also I am not sure why some tests are failing for continous.py and discrete.py

Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance and covariance.
Updated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality.
@tanishy7777
Copy link
ContributorAuthor

tanishy7777 commentedNov 28, 2024•
edited
Loading

I have updated all the files that need to be changes in the pymc/distributions folder. Please let me know if any other changes need to be made or if anything needs to be modified@ricardoV94@twiecki

@AtulBoyal
Copy link

Hi, I noticed that PR#7573 has been inactive for 5 months. Is this issue still open for contribution? If the original contributor is unavailable, I’d love to work on it!

@tanishy7777
Copy link
ContributorAuthor

Hi, I noticed that PR#7573 has been inactive for 5 months. Is this issue still open for contribution? If the original contributor is unavailable, I’d love to work on it!

Hey, I think I have already made all of the changes required by this issue. But please go ahead if you find any more places where the changes need to be made. From my end the PR is done. I was waiting for the approval from the maintainers.

@tanishy7777
Copy link
ContributorAuthor

@ricardoV94@twiecki Just wanted to remind you about this PR. Please have a look at it at your convenience.

@twieckitwiecki changed the titleFix for issue #7563Replaced "log-likelihood" with "distribution" in for all the classes where distributions is more appropriate rather than log-likelihood.Mar 14, 2025
@twieckitwiecki merged commitaf81955 intopymc-devs:mainMar 14, 2025
2 of 3 checks passed
@welcome
Copy link

welcomebot commentedMar 14, 2025

Congratulations Banner]
Congrats on merging your first pull request! 🎉 We here atPyMC are proud of you! 💖 Thank you so much for your contribution 🎁

@twiecki
Copy link
Member

Thanks!

tanishy7777 reacted with thumbs up emoji

vandalt pushed a commit to vandalt/pymc that referenced this pull requestMay 14, 2025
…where distributions is more appropriate rather than log-likelihood. (pymc-devs#7573)* Update multivariate.pyUpdated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including cdf, mean, and random methods.* Update multivariate.pyUpdated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance, covariance.* Update continuous.pyUpdated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance, covariance, etc.* Update discrete.pyUpdated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance, covariance.* Update distribution.pyUpdated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood including log-cdf, log-pdf.* Update mixture.pyUpdated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality, as the class provides more than just log-likelihood, including mean, variance and covariance.* Update timeseries.pyUpdated the docstrings for better clarity. Replaced "log-likelihood" with "distribution" to accurately describe the functionality.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@twieckitwieckitwiecki approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docstrings of distributions should not readx log-likelihood

4 participants

@tanishy7777@ricardoV94@AtulBoyal@twiecki
[8]ページ先頭
©2009-2025 Movatter.jp