- Notifications
You must be signed in to change notification settings - Fork11
Import setup from setuptools#12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
stefanor wants to merge1 commit intopylint-dev:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
setuptools 60 uses its own bundled version of distutils, by default. Itinjects this into sys.modules, at import time. So we need to make surethat it is imported, before anything else imports distutils, to ensureeverything is using the same distutils version.This change in setuptools is to prepare for Python 3.12, which will dropdistutils.In this case, the best way to deal with the problem is to just usesetuptools' setup().Fixes:https://bugs.debian.org/1022481
FWIW, the underlying bug I was describing ishttps://bugs.debian.org/1025216 but this change is still a worthwhile cleanup, I think. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools 60 uses its own bundled version of distutils, by default. It injects this into sys.modules, at import time. So we need to make sure that it is imported, before anything else imports distutils, to ensure everything is using the same distutils version.
This change in setuptools is to prepare for Python 3.12, which will drop distutils.
In this case, the best way to deal with the problem is to just use setuptools' setup().
Fixes:https://bugs.debian.org/1022481