Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Alter fallback for source-roots#9967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
akamat10 wants to merge9 commits intopylint-dev:main
base:main
Choose a base branch
Loading
fromakamat10:disable_legacy_for_source_roots

Conversation

akamat10
Copy link
Contributor

@akamat10akamat10 commentedSep 25, 2024
edited
Loading

Type of Changes

Type
✨ New feature
📜 Docs

Description

Alter fallback for source-roots as discussed in#9955. This simplifies the import discovery logic, makes it easier to understand and supports the discovery process for more usecases (for example, src-layout or in cases where imported modules may be in a different directory from the files to be linted)

TODO:

  • Changelog
  • Documentation

Update changelog and documentation

Closes#9955

@codecovCodecov
Copy link

codecovbot commentedSep 25, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is83.33333% with2 lines in your changes missing coverage. Please review.

Project coverage is 95.80%. Comparing base(c0ecd70) to head(fed3e42).
Report is 27 commits behind head on main.

Files with missing linesPatch %Lines
pylint/lint/expand_modules.py83.33%2 Missing⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@##             main    #9967      +/-   ##==========================================- Coverage   95.80%   95.80%   -0.01%==========================================  Files         174      174                Lines       18934    18939       +5     ==========================================+ Hits        18140    18144       +4- Misses        794      795       +1
Files with missing linesCoverage Δ
pylint/lint/pylinter.py96.65% <ø> (ø)
pylint/pyreverse/main.py93.75% <ø> (ø)
pylint/lint/expand_modules.py94.44% <83.33%> (-0.85%)⬇️

@github-actionsGitHub Actions

This comment has been minimized.

@akamat10akamat10force-pushed thedisable_legacy_for_source_roots branch from648b52c to2c0c0d6CompareSeptember 29, 2024 05:28
@akamat10akamat10 marked this pull request as ready for reviewSeptember 29, 2024 05:55
@github-actionsGitHub Actions

This comment has been minimized.

@DudeNr33DudeNr33 removed their request for reviewSeptember 29, 2024 13:51
@DudeNr33
Copy link
Collaborator

As this is not primarily aboutpyreverse, I have unassigned me from the review.

Pierre-Sassoulas reacted with thumbs up emoji

@Pierre-SassoulasPierre-Sassoulas added Needs review 🔍Needs to be reviewed by one or multiple more persons Import system Skip news 🔇This change does not require a changelog entry labelsSep 29, 2024
@akamat10akamat10force-pushed thedisable_legacy_for_source_roots branch from2bae088 to6ef3156CompareSeptember 29, 2024 16:55
@github-actionsGitHub Actions

This comment has been minimized.

@github-actionsGitHub Actions
Copy link
Contributor

🤖 According to the primer, this change hasno effect on the checked open source code. 🤖🎉

This comment was generated for commitfed3e42

@DanielNoord
Copy link
Collaborator

@akamat10 Can you tag me when this is ready for review?

@akamat10
Copy link
ContributorAuthor

Will do!

@jacobtylerwalls
Copy link
Member

Hi@akamat10 👋

Just checking in on this PR. Do you think you'll have the chance to pick up where you left off? pylint main is now compatible with astroid main, btw.

@akamat10
Copy link
ContributorAuthor

Yes I would love to. Haven't had the chance the last few months as I got busy with some life changes. Also, when I last looked at it, the regression test failures were a little tricky to unravel trying to understand the intent of the test and some unrelated to my changes in the main branch. I will be able to look at it starting March 1st. What kind of timelines do you have in mind for the release?

jacobtylerwalls reacted with thumbs up emoji

@jacobtylerwalls
Copy link
Member

The last couple years we've timed the feature release to add compatibility with a new python version in early October, so assuming we do that again you will have plenty of time :)

@akamat10
Copy link
ContributorAuthor

Ok sounds good. I will have some update in the first week of March.

jacobtylerwalls reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Import systemNeeds review 🔍Needs to be reviewed by one or multiple more personsSkip news 🔇This change does not require a changelog entry
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Alter fallback whensource-root based package path discovery when a source root containing the module directory is not found
5 participants
@akamat10@DudeNr33@DanielNoord@jacobtylerwalls@Pierre-Sassoulas

[8]ページ先頭

©2009-2025 Movatter.jp