Seeastral-sh/ruff#11421 for initial reasoning behind this. I think we should modify the way we compute match case. But not sure if we should add a new visit method in pylint or add aget_children method for match case in astroid so we ends up not having to modify anything on the pylint side (and would benefit from it elsewhere too ?).

Pierre-Sassoulas added Discussion 🤔 Needs specification 🔐Accepted as a potential improvement, and needs to specify edge cases, message names, etc. labels

May 22, 2024

Pierre-Sassoulas requested a review fromcdce8p

May 22, 2024 07:22

This comment has been minimized.

Copy link

Member

cdce8p commentedJun 8, 2024

But not sure if we should add a new visit method in pylint or add aget_children method for match case in astroid so we ends up not having to modify anything on the pylint side (and would benefit from it elsewhere too ?).

get_children should already work same asvisitMatchCase. I haven't looked into themccabe extension yet, so not sure I can really help with that at this point.

cdce8p removed their request for review

June 8, 2024 08:37

Add a test case for too-complex in match case, for discussion

b1ba516

Pierre-Sassoulas force-pushed thematch-case-too-complex branch from1096f19 tob1ba516Compare

November 20, 2024 21:45

Copy link

Contributor

github-actionsbot commentedNov 20, 2024

🤖 According to the primer, this change hasno effect on the checked open source code. 🤖🎉

This comment was generated for commitb1ba516

Labels

Discussion 🤔Needs specification 🔐

Accepted as a potential improvement, and needs to specify edge cases, message names, etc.

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add a test case for`too-complex` in match case, for discussion#9667

Are you sure you want to change the base?

Add a test case for`too-complex` in match case, for discussion#9667

Uh oh!