Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

allow-global-unused-variables should respect dummy-variables-rgx#9570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
com6056 wants to merge4 commits intopylint-dev:main
base:main
Choose a base branch
Loading
fromcom6056:patch-1

Conversation

com6056
Copy link

@com6056com6056 commentedApr 25, 2024
edited
Loading

Type of Changes

Type
🐛 Bug fix

Description

Right now,--allow-global-unused-variables=no doesn't respect--dummy-variables-rgx, I believe this should fix it 🤞

Refs#8174

Closes#8174

@com6056com6056 marked this pull request as ready for reviewApril 25, 2024 16:40
@github-actionsGitHub Actions

This comment has been minimized.

@com6056
Copy link
Author

Not sure if this change requires news or not, let me know if it does though! I just don't have all the tools installed to regenerate everything but can get that going if needed.

@DanielNoord
Copy link
Collaborator

This would indeed require a news entry, if you don't want to install the tools you can probably copy one from a previous PR and see what the syntax looks like there.

@codecovCodecov
Copy link

codecovbot commentedApr 29, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is50.00000% with1 line in your changes missing coverage. Please review.

Project coverage is 95.81%. Comparing base(67bfab4) to head(e80d0a5).
Report is 443 commits behind head on main.

Files with missing linesPatch %Lines
pylint/checkers/variables.py50.00%1 Missing⚠️

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@##             main    #9570      +/-   ##==========================================- Coverage   95.81%   95.81%   -0.01%==========================================  Files         173      173                Lines       18825    18827       +2     ==========================================+ Hits        18038    18039       +1- Misses        787      788       +1
Files with missing linesCoverage Δ
pylint/checkers/variables.py97.28% <50.00%> (-0.07%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@com6056
Copy link
Author

This would indeed require a news entry, if you don't want to install the tools you can probably copy one from a previous PR and see what the syntax looks like there.

Done! Just peeked at some other PRs, took a few tries but seems like it is happy now haha, let me know if there's anything else needed before we can get this merged in! 🎉

Copy link
Member

@Pierre-SassoulasPierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening a PR. I do think we need to think about#8013 before "fixing" this. There's a bad/ "two options in parallel" initial design and we need to restore consistency (and document this better then close#8013 in this MR, if this MR restore consistency).

@Pierre-SassoulasPierre-Sassoulas added this to the3.2.0 milestoneApr 29, 2024
@Pierre-SassoulasPierre-Sassoulas added the Enhancement ✨Improvement to a component labelApr 29, 2024
@github-actionsGitHub Actions
Copy link
Contributor

🤖 According to the primer, this change hasno effect on the checked open source code. 🤖🎉

This comment was generated for commite80d0a5

@com6056
Copy link
Author

Thank you for opening a PR. I do think we need to think about#8013 before "fixing" this. There's a bad/ "two options in parallel" initial design and we need to restore consistency (and document this better then close#8013 in this MR, if this MR restore consistency).

Any idea how long this will take? Could I instead just add a new flag that allows you instead to opt-in to this behavior then if it might take a while to resolve#8013?

@Pierre-Sassoulas
Copy link
Member

If you can propose a consistent design it could be fast, otherwise we need to wait for someone else to think this is important and volunteer to think about it. Maybe the current MR is enough and making them mutually exclusive and using only one option at a time is not the way to go. But it should be argumented/documented. Right now I feel we're fixing a particular use case, instead of actually fixing the root issue and are going to throw all this when actually looking into it.

@com6056
Copy link
Author

com6056 commentedMay 3, 2024
edited
Loading

Where in the docs should I add this? And what do you mean by "argumented"? Should I add another CLI flag that enables this?

@Pierre-Sassoulas
Copy link
Member

And what do you mean by "argumented"? Should I add another CLI flag that enables this?

Sorry I was thinking in french, I actually meant argued / reasoned that the better solution is to keep both options and not make them mutually exclusive. We would need to document both of the options if that's the case (here

"help":"A regular expression matching the name of dummy "
).

@jacobtylerwallsjacobtylerwalls modified the milestones:3.2.0,3.3.0May 7, 2024
@Pierre-SassoulasPierre-Sassoulas modified the milestones:3.3.0,3.4.0Sep 20, 2024
@jacobtylerwallsjacobtylerwalls modified the milestones:3.4.0,4.0.0Sep 25, 2024
@DanielNoordDanielNoord added the Needs take over 🛎️Orignal implementer went away but the code could be salvaged. labelMar 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Pierre-SassoulasPierre-SassoulasPierre-Sassoulas requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Enhancement ✨Improvement to a componentNeeds take over 🛎️Orignal implementer went away but the code could be salvaged.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

allow-global-unused-variables doesn't respectdummy-variables-rgx
4 participants
@com6056@DanielNoord@Pierre-Sassoulas@jacobtylerwalls

[8]ページ先頭

©2009-2025 Movatter.jp