We should wait until we can test 3.14 in CI before merging this.

I also don't really like that we need to duplicate a lot of tests. Maybe we can come up with a better solution for dealing conditional errors in our tests.

Great !

We should wait until we can test 3.14 in CI before merging this.

Agree, so it's Blocked bypylint-dev/astroid#2731 and then the pylint equivalent.

I also don't really like that we need to duplicate a lot of tests. Maybe we can come up with a better solution for dealing conditional errors in our tests.

Maybe time to design something to be able to expect something different according to the version ?
filename.py

something=1# [unused-variable|>=3.13,missing-module-docstring]

Withfilename.3.14.txt for the expected output of 3.14,filename.txt for the default expected output if the interpreter does not have its specific output file...

I also don't really like that we need to duplicate a lot of tests. Maybe we can come up with a better solution for dealing conditional errors in our tests.

Maybe time to design something to be able to expect something different according to the version ?filename.py

something=1# [unused-variable|>=3.13,missing-module-docstring]

Withfilename.3.14.txt for the expected output of 3.14,filename.txt for the default expected output if the interpreter does not have its specific output file...

Explored something like this in#10382. The diff here would look much better, see379ab07.

🤖 According to the primer, this change hasno effect on the checked open source code. 🤖🎉

This comment was generated for commit379ab07