Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2k
Comments
_pyi_machine: Avoid using platform.machine() directly#9377
_pyi_machine: Avoid using platform.machine() directly#9377iv-m wants to merge 1 commit intopyinstaller:developfrom
Conversation
iv-m commentedFeb 18, 2026
@bwoodsend,@wangling12, please take a look. |
rokm commentedFeb 18, 2026 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This seems to break bootloader compilation in |
iv-m commentedFeb 18, 2026
Yup, |
rokm commentedFeb 18, 2026 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
What exactly is it that you are trying to fix, though? I.e., what is wrong with the current approach for these two platforms? |
rokm commentedFeb 19, 2026
Note that PyInstaller uses a vendored copy of pyinstaller/bootloader/waflib/Tools/c_config.py Lines 40 to 62 ina7a674a
waflib. |
The
machineargument sould be used on all platforms. This change fixes _pyi_machine tests on loongarch64.Fixes:b194152
Fixes:018fa3f