- Notifications
You must be signed in to change notification settings - Fork3.8k
Updating "Python Pygame Introduction"#3918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Updated the resolution size of the code snippet to 1920 x 1080. The previous resolution was extremely small and caused the ball to bounce too fast. Added some clarification about making sure the intro_ball.gif file can be found by the code snippet. The snippet itself was not displaying properly either. Added an image file to display it instead of formatting
| pygame modules. | ||
| The call to ``pygame.init()`` initializes each of these modules. | ||
| Make sure the gif file of the bouncing ball is in the same folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a nice change, thanks.
docs/reST/tut/PygameIntro.rst Outdated
| screen.fill(black) | ||
| screen.blit(ball, ballrect) | ||
| pygame.display.flip() | ||
| ..image::introsnippet.PNG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think the code listing should be removed for an image. One reason is the code listing can be copy/pasted, but the image not.
Can you please remove this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
let me know if the new edit is ok, the reasoning is, the code block doesn't show up at all on the github page, but I don't want to negatively impacthttps://www.pygame.org/docs/tut/PygameIntro.html, i can remove the change altogether and go back to how it was if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It seems removing the linenos fixed it so it displays in github again. Thanks.
Can you please remove the png file from the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks.
I left a request about adding the code listing back.
Took out image from rst file and using ..codeblock instead. The code block was not displaying at all on github, but you could see it herehttps://www.pygame.org/docs/tut/PygameIntro.htmlThe problem was there needs to be a blank space after.. code-block:: python line,BUT now the line numbers are not displaying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🎉 thanks :)
Updated the resolution size of the code snippet to 1920 x 1080. The previous resolution was extremely small and caused the ball to bounce too fast. Added some clarification about making sure the intro_ball.gif file can be found by the code snippet. The snippet itself was not displaying properly either. Added an image file to display it instead of formatting in github