- Notifications
You must be signed in to change notification settings - Fork3.8k
Adjust surface masks to create a proper 24 bit Surface#3577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The SDL 2.26.0 pre-release rejects a 24 bit Surface created with this mask, which is the right call, as it needs 32 bits of space. Older SDL went ahead and created a 32 bit surface anyway, which it probably shouldn't have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This change makes sense, though I'm slightly concerned since this is behaviour changing. But I don't think it would bread much "real code" so I'll go ahead and approve. Thanks 🎉
Also unrelated to this PR, but these mask numbers would probably make more visual sense when written in hex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍
https://build.opensuse.org/request/show/1042426by user dgarcia + dimstar_suse- Add adjust-surface-mask.patch gh#pygame/pygame#3577, to fix tests with SDL 2.26.0.
The SDL 2.26.0 pre-release rejects a 24 bit Surface created with this mask, which is the right call, as it needs 32 bits of space. Older SDL went ahead and created a 32 bit surface anyway, which it probably shouldn't have.