Looks like the linter is complaining:

'clang-format' failed. Please run: python setup.py format Do you have the latest version of clang-format?

if you haveclang-format installed (Install guide) (python package:https://pypi.org/project/clang-format/) it should just be a quick:

clang-format src_c/event.c -i

from the pygame directory in the console.

Hi, thanks for the PR! 🎈

This PR looks almost good, but for the sake of better robustness I think more changes need doing around these bits of code. If you are interested, it'd be nice if you could do these changes in this PR. Otherwise we could also merge this PR first, and me or someone else could do a follow up PR later.

The issue here is thatevent->window.windowID is only guaranteed to be the correct way for accessingwindowID attributes ofWINDOW* events. It just so happens that this also works for some more events because of how the internal union withinSDL_Event is defined. And as you figured out, this way of accessing is wrong for drop events (and one must not attempt to do this either, because this is basically undefined behavior and you will get a garbage id because the wrong memory location is being accessed)

Initialise window to 0 then slapSDL_GetWindowFromID(event->window.windowID); into an else block?

Hi, thanks for the PR! 🎈

This PR looks almost good, but for the sake of better robustness I think more changes need doing around these bits of code. If you are interested, it'd be nice if you could do these changes in this PR. Otherwise we could also merge this PR first, and me or someone else could do a follow up PR later.

The issue here is thatevent->window.windowID is only guaranteed to be the correct way for accessingwindowID attributes ofWINDOW* events. It just so happens that this also works for some more events because of how the internal union withinSDL_Event is defined. And as you figured out, this way of accessing is wrong for drop events (and one must not attempt to do this either, because this is basically undefined behavior and you will get a garbage id because the wrong memory location is being accessed)

I add 2 lines here

And I get this

Maybe there is a bug in SDL library.

I mean the code should be like this:

SDL_Window *window = 0;if (event->type == SDL_DROPTEXT || event->type == SDL_DROPFILE) {    window = SDL_GetWindowFromID(event->drop.windowID);}else{    window = SDL_GetWindowFromID(event->window.windowID);}PyObject *pgWindow;if (!window || !(pgWindow = SDL_GetWindowData(window, "pg_window"))) {    pgWindow = Py_None;}Py_INCREF(pgWindow);_pg_insobj(dict, "window", pgWindow);break;

Maybe there is a bug in SDL library.

This is not a bug, rather it's a side effect of how the underlyingunion is implemented in the event struct. With unions, you can have multiple names to access the same memory block.

I mean the code should be like this

Yeah, the code you suggested will do for now, but for robustness I'd like the splitting of this large switch statement into the correct sub-categories, something like (untested code).

SDL_Window*window;switch (event->type) {casePGE_WINDOWSHOWN:casePGE_WINDOWHIDDEN:casePGE_WINDOWEXPOSED:casePGE_WINDOWMOVED:casePGE_WINDOWRESIZED:casePGE_WINDOWSIZECHANGED:casePGE_WINDOWMINIMIZED:casePGE_WINDOWMAXIMIZED:casePGE_WINDOWRESTORED:casePGE_WINDOWENTER:casePGE_WINDOWLEAVE:casePGE_WINDOWFOCUSGAINED:casePGE_WINDOWFOCUSLOST:casePGE_WINDOWCLOSE:casePGE_WINDOWTAKEFOCUS:casePGE_WINDOWHITTEST:casePGE_WINDOWICCPROFCHANGED:casePGE_WINDOWDISPLAYCHANGED:window=SDL_GetWindowFromID(event->window.windowID);break;caseSDL_TEXTEDITING:caseSDL_TEXTINPUT:window=SDL_GetWindowFromID(event->edit.windowID);break;caseSDL_DROPTEXT:caseSDL_DROPFILE:window=SDL_GetWindowFromID(event->drop.windowID);break;caseSDL_MOUSEWHEEL:window=SDL_GetWindowFromID(event->wheel.windowID);break;caseSDL_KEYDOWN:caseSDL_KEYUP:window=SDL_GetWindowFromID(event->key.windowID);break;caseSDL_MOUSEMOTION:window=SDL_GetWindowFromID(event->motion.windowID);break;caseSDL_MOUSEBUTTONDOWN:caseSDL_MOUSEBUTTONUP:window=SDL_GetWindowFromID(event->button.windowID);break;default:/* Event doesn't have a "window" attribute. Can exit the function early */returndict;    }/* Handle "window" here */PyObject*pgWindow;if (!window||        !(pgWindow=SDL_GetWindowData(window,"pg_window"))) {pgWindow=Py_None;    }Py_INCREF(pgWindow);_pg_insobj(dict,"window",pgWindow);returndict;

I mean the code should be like this

Yeah, the code you suggested will do for now, but for robustness I'd like the splitting of this large switch statement into the correct sub-categories, something like (untested code).

SDL_Window*window;switch (event->type) {casePGE_WINDOWSHOWN:casePGE_WINDOWHIDDEN:casePGE_WINDOWEXPOSED:casePGE_WINDOWMOVED:casePGE_WINDOWRESIZED:casePGE_WINDOWSIZECHANGED:casePGE_WINDOWMINIMIZED:casePGE_WINDOWMAXIMIZED:casePGE_WINDOWRESTORED:casePGE_WINDOWENTER:casePGE_WINDOWLEAVE:casePGE_WINDOWFOCUSGAINED:casePGE_WINDOWFOCUSLOST:casePGE_WINDOWCLOSE:casePGE_WINDOWTAKEFOCUS:casePGE_WINDOWHITTEST:casePGE_WINDOWICCPROFCHANGED:casePGE_WINDOWDISPLAYCHANGED:window=SDL_GetWindowFromID(event->window.windowID);break;caseSDL_TEXTEDITING:caseSDL_TEXTINPUT:window=SDL_GetWindowFromID(event->edit.windowID);break;caseSDL_DROPTEXT:caseSDL_DROPFILE:window=SDL_GetWindowFromID(event->drop.windowID);break;caseSDL_MOUSEWHEEL:window=SDL_GetWindowFromID(event->wheel.windowID);break;caseSDL_KEYDOWN:caseSDL_KEYUP:window=SDL_GetWindowFromID(event->key.windowID);break;caseSDL_MOUSEMOTION:window=SDL_GetWindowFromID(event->motion.windowID);break;caseSDL_MOUSEBUTTONDOWN:caseSDL_MOUSEBUTTONUP:window=SDL_GetWindowFromID(event->button.windowID);break;default:/* Event doesn't have a "window" attribute. Can exit the function early */returndict;    }/* Handle "window" here */PyObject*pgWindow;if (!window||        !(pgWindow=SDL_GetWindowData(window,"pg_window"))) {pgWindow=Py_None;    }Py_INCREF(pgWindow);_pg_insobj(dict,"window",pgWindow);returndict;

Thank you. The code is modified now.
I also addedSDL_FINGERMOTION,SDL_FINGERDOWN andSDL_FINGERUP into thecase.

caseSDL_FINGERMOTION:caseSDL_FINGERDOWN:caseSDL_FINGERUP: {window=SDL_GetWindowFromID(event->tfinger.windowID);break;}

Why? I don't understand. Is it a problem about wrong SDL version? But thesdl wiki indicates that'This structure is available since SDL 2.0.0.'

Looks like that build uses SDL 2.0.8 released in 2018, andwindowID was added in 2019.

see:

https://discourse.libsdl.org/t/sdl-2-0-8-released/23957

and:

libsdl-org/SDL@d5ec735
libsdl-org/SDL@2fb71ac
libsdl-org/SDL@109cbd6

Thanks for making this PR! I notice that theevents documentation describes what attributes each type of event should have, so that should be updated for this.

Edit here:https://github.com/pygame/pygame/blob/main/docs/reST/ref/event.rst
It would also be good to put in a "versionchanged" tag for this in the documentation there.

Not sure about the latest commit that documents this should be a part of this PR. This is a feature that has been left undocumented so far because it has to do with_sdl2 which isn't public and stable.

Not sure about the latest commit that documents this should be a part of this PR. This is a feature that has been left undocumented so far because it has to do with _sdl2 which isn't public and stable.

Lets just go ahead and put it out. The underlying SDL event provides the window data, so when we're all caught up with SDL this will be like this anyways.

You okay with that@ankith26 ?

Ok@yunline, I talked to Ankith about it and he was still against documenting this.
So I went ahead and reverted the commit on your PR branch, we'll merge it when the tests pass.

Nice work!