As far as I can tell there is no obvious reasonnot to have inline functions in header files with Pygame 3. The existing #define style 'functions' ininclude/_pygame.h appear to have been designed that way for something calledCObjects in Python 2 (according to the header comment in the file) which were then removed in Python 3.

Happy to hear wisdom otherwise, or create a new file instead if we think that is better, but the existing #define macro functions in this header are the most similar to the purpose of this function. Also, this header is already included everywhere.

Testing work: does this change the performance in any way versus having it directly inrect.c. It shouldn't but hey, compilers are weird.

Move pg_tuple_from_values_int into _pygame header file

cacabb8

Copy link

ContributorAuthor

MyreMylar commentedNov 1, 2022•
edited
Loading

Relatedly, I found this accepted PEP on removing macros from python in favour of inline functions:

https://peps.python.org/pep-0670/

Make pg_tuple_from_values_int static as well

124642b

Copy link

Contributor

Starbuck5 commentedNov 5, 2022

It would be great to have a comment with the function explaining its function and purpose.

iirc:
Converts two integers to a python tuple faster than the general purpose PyBuild_Value way.

Copy link

ContributorAuthor

MyreMylar commentedNov 5, 2022

It would be great to have a comment with the function explaining its function and purpose.
iirc: Converts two integers to a python tuple faster than the general purpose PyBuild_Value way.

Yeah, I think we will also want to rename this to "couple" and create a second version "triple" for three values into a tuple.

I can rejig this PR - or we could keep this one as a simple move and do the rename, rejig an comments in a new PR? Dunno what would be preferred for ease of review.

Copy link

Contributor

Starbuck5 commentedNov 5, 2022

I’d prefer comment now and rejig later if at all.

That puts us in a good spot for readability now and potentially later.

switch to couple & triple variants of values to tuple

d32440a

- Also add explanatory comment for why this was made

Copy link

ContributorAuthor

MyreMylar commentedNov 5, 2022

Decided to just do the rename now and triple variant now as well.

The triple will likely be used for thecolor.rgb setter in that PR

Copy link

Contributor

itzpr3d4t0r commentedNov 6, 2022

In our pygame_geometry project we settled on a different name for the function that i think is a bit better than this one, though i'll just throw it out there, no forcing:
pg_TupleFromIntPair

Copy link

ContributorAuthor

MyreMylar commentedNov 6, 2022

In our pygame_geometry project we settled on a different name for the function that i think is a bit better than this one, though i'll just throw it out there, no forcing:pg_TupleFromIntPair

Now I'm just annoyed about the rapid switching between CamelCase and underscores in function names all over pygame...

Anyway, I'm happy to switch to whatever name or case arrangement as long as we have a logical way to distinguish between the couple/pair tuple and the triple/trio and are consistent.