- Notifications
You must be signed in to change notification settings - Fork3.9k
Compile freetype with harfbuzz, reduce manylinux wheelsize#3445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
NextNext commit
Add latest pkg-config to manylinux docker images
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
3 changes: 3 additions & 0 deletionsbuildconfig/manylinux-build/docker_base/Dockerfile-aarch64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletionsbuildconfig/manylinux-build/docker_base/Dockerfile-i686
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletionsbuildconfig/manylinux-build/docker_base/Dockerfile-x86_64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletionsbuildconfig/manylinux-build/docker_base/pkg-config/build-pkg-config.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #!/bin/bash | ||
| # This file exists because pkg-config is too old on manylinux docker centos | ||
| # images (the older version segfaults if it gets a cyclic dependency, like | ||
| # freetype2+harfbuzz) | ||
| set -e -x | ||
| cd $(dirname `readlink -f "$0"`) | ||
| # We save the compiled-in PKG_CONFIG_PATH of the pre-existing pkg-config, and | ||
| # re-use it with the new pkg-config | ||
| COMPILED_PKGCONFIG_DIRS=$(pkg-config --variable pc_path pkg-config) | ||
| # append path(s) where other installs put .pc files | ||
| COMPILED_PKGCONFIG_DIRS="${COMPILED_PKGCONFIG_DIRS}:/usr/local/lib/pkgconfig" | ||
| PKGCONFIG=pkg-config-0.29.2 | ||
| curl -sL --retry 10 https://pkg-config.freedesktop.org/releases/${PKGCONFIG}.tar.gz > ${PKGCONFIG}.tar.gz | ||
| sha512sum -c pkg-config.sha512 | ||
| tar xzf ${PKGCONFIG}.tar.gz | ||
| cd $PKGCONFIG | ||
| # Passing --with-internal-glib will make this pickup internally vendored glib | ||
| # Use this flag if there are build issues with this step later on | ||
| ./configure $ARCHS_CONFIG_FLAG --with-pc-path=$COMPILED_PKGCONFIG_DIRS | ||
| make | ||
| make install | ||
| if [[ "$OSTYPE" == "darwin"* ]]; then | ||
| # Install to mac deps cache dir as well | ||
| make install DESTDIR=${MACDEP_CACHE_PREFIX_PATH} | ||
| fi |
1 change: 1 addition & 0 deletionsbuildconfig/manylinux-build/docker_base/pkg-config/pkg-config.sha512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 4861ec6428fead416f5cbbbb0bbad10b9152967e481d4b0ff2eb396a9f297f552984c9bb72f6864a37dcd8fca1d9ccceda3ef18d8f121938dbe4fdf2b870fe75 pkg-config-0.29.2.tar.gz |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.