- Notifications
You must be signed in to change notification settings - Fork3.8k
Relax SDL minor version exact match check#3428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
How does this change to the versioning system handle old versions of SDL still out in the wild? |
smcv commentedAug 26, 2022
No change. All the stable versions of SDL2 released before 2.24.0 were of the form 2.0.x, where 2.0.x is backwards-compatible with 2.0.y, for any x >= y. It is still true that 2.0.x is backwards-compatible with 2.0.y for any x >= y. What has changed is that before 2.24, SDL upstream didn't specify whether 2.x.a is compatible with 2.y.b, where x != y. Before this MR, pygame pessimistically assumed that a minor version change is a compatibility break, similar to the way SDL 1 worked (SDL 1.2 was incompatible with SDL 1.3). Since 2.24, SDL upstream is declaring that all (stable) versions of |
smcv commentedAug 26, 2022
I see pygame uses |
ankith26 commentedAug 26, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I've tested this patch on windows (by replacing |
smcv commentedAug 26, 2022
I'm not a pygame maintainer or contributor, but this looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK, after reading the discussion and on a second look though this all seems reasonable. I'm approving. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me. Thanks for handling this Ankith, and thanks for the report smcv!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
fixes#3427