- Notifications
You must be signed in to change notification settings - Fork3.8k
test.test_utils.run_tests.py: Fix exit using RuntimeError for better message#3382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
If you somehow run this file without knowing which file exactly you are running you will get no information, just "This module is for import only", So you will need to check every single file that was runned. Replaced it with raise ValueError() because it says what happened, and where.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the first time contribution! 🎉 🥳
Left a minor review for you to address before this is merged, but the idea behind this PR sounds good to me
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure!
If you somehow run this file without knowing which file exactly you are running, you will get no information, just "This module is for import only", So you will need to check every single file that was executed.
Fix:
Replaced it with raise ValueError() because it says what happened, and where exactly.