Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix some METH_NOARGS usage, use METH_O where possible#3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
MyreMylar merged 3 commits intomainfromankith26-meth-o
Aug 14, 2022

Conversation

@ankith26
Copy link
Contributor

This PR is primarily intended for better code quality and better error reporting, but this also helps a (really tiny) bit with performance.

Some functions that were supposed to beMETH_NOARGS wereMETH_VARAGS (which means that you could pass any arbitrary arguments to these functions and python would not complain)

I also tried to applyMETH_O in some places where they make the code clearer

Copy link
Contributor

@Starbuck5Starbuck5 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is quite an impressive roundup! I read through everything and ran the tests locally, it looks good to me.

Left a couple minor comments for you to decide what to do with.

Copy link
Contributor

@MyreMylarMyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

Tests all pass locally on my windows machine.

@illumeillume added the PerformanceRelated to the speed or resource usage of the project labelOct 29, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@MyreMylarMyreMylarMyreMylar approved these changes

@Starbuck5Starbuck5Starbuck5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C codeInvolves changing C codeCode quality/robustnessCode quality and resilience to changesPerformanceRelated to the speed or resource usage of the project

Projects

None yet

Milestone

2.1.3

Development

Successfully merging this pull request may close these issues.

5 participants

@ankith26@MyreMylar@Starbuck5@illume
[8]ページ先頭
©2009-2025 Movatter.jp