- Notifications
You must be signed in to change notification settings - Fork3.8k
Use macos-12 for all Mac CI builds#3347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM if the tests all pass
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! I'm curious why you decided to go 12 instead of 11.
Just to be more future safe. mac 11 will be removed before mac 12 y'know 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🎉 safe. Future. Nice.
I guess someone tested with older macs?
Github Actions is removing mac 10.15 runners
This PR does a simple version bump to mac 12, this should hopefully not have much of an impact on our builds (the intel wheels will continue to be built with mac 10.9+ support and the mac arm builds should continue supporting mac 11+)