Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

BGRA format added to fromstring & tostring#3342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
MyreMylar merged 5 commits intopygame:mainfromrlatowicz:BGRA_branch
Jul 31, 2022
Merged

BGRA format added to fromstring & tostring#3342

MyreMylar merged 5 commits intopygame:mainfromrlatowicz:BGRA_branch
Jul 31, 2022

Conversation

@rlatowicz
Copy link
Contributor

@rlatowiczrlatowicz commentedJul 25, 2022•
edited by illume
Loading

So you can also use buffers where the data is in 32bit RGBA order.

bgra_surf=pygame.image.frombuffer(bgra_buffer, (4,4),"BGRA")

Starbuck5 and illume reacted with hooray emoji
@Starbuck5
Copy link
Contributor

Hey, sorry no one has had the time to review this thoroughly yet. Just wanted to give you a reply so you know somebody is tracking 😅.

Everything I've looked at has looked good so far. Testing changes seem elegant, C code changes seem straightforward.

rlatowicz reacted with thumbs up emoji

@rlatowicz
Copy link
ContributorAuthor

@Starbuck5

Thanks.
I appreciate the update.

@rlatowicz
Copy link
ContributorAuthor

@Starbuck5

I hope to make the changes to those areas, you have referred to, later tonight or tomorrow.

Thanks.

Starbuck5 reacted with thumbs up emoji

@rlatowicz
Copy link
ContributorAuthor

@Starbuck5

Thanks again.

I also noticed thattest_frombuffer_BGRA() needed some name changes.

Done!

Copy link
Contributor

@Starbuck5Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me! Thanks for doing the work on this!

I'm interested to see if that performance idea does anything, it could probably be applied widely if it pans out.

rlatowicz reacted with thumbs up emoji
Copy link
Contributor

@MyreMylarMyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

rlatowicz reacted with thumbs up emoji
@rlatowiczrlatowicz deleted the BGRA_branch branchAugust 1, 2022 09:44
@illumeillume added the New APIThis pull request may need extra debate as it adds a new class or function to pygame labelOct 29, 2022
lazka added a commit to lazka/pycairo that referenced this pull requestApr 13, 2025
* FORMAT_ARGB32 is equivalent to BGRA in pygame and not ARGB.* BGRA support in pygame was added with 2.1.3 viapygame/pygame#3342* Update pygame example to use more colors and alpha to verify* Bump the pygame requirements for the tests* Adjust the docs and note the pygame version requirementFixespygobject#247
lazka added a commit to pygobject/pycairo that referenced this pull requestApr 13, 2025
* FORMAT_ARGB32 is equivalent to BGRA in pygame and not ARGB.* BGRA support in pygame was added with 2.1.3 viapygame/pygame#3342* Update pygame example to use more colors and alpha to verify* Bump the pygame requirements for the tests* Adjust the docs and note the pygame version requirementFixes#247
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@Starbuck5Starbuck5Starbuck5 approved these changes

@MyreMylarMyreMylarMyreMylar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementimagepygame.imageNew APIThis pull request may need extra debate as it adds a new class or function to pygame

Projects

None yet

Milestone

2.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@rlatowicz@Starbuck5@MyreMylar@illume
[8]ページ先頭
©2009-2025 Movatter.jp