Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Cleaned up draw.aaline() code for small speedup#3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ankith26 merged 1 commit intopygame:mainfromitzpr3d4t0r:aaline_change
Jul 14, 2022

Conversation

@itzpr3d4t0r
Copy link
Contributor

@itzpr3d4t0ritzpr3d4t0r commentedJul 13, 2022•
edited
Loading

A simple change that removed the unnecessary use of an array only to assign it and access it right after.
Small performance benefit aswell

Starbuck5 and ankith26 reacted with rocket emoji
Copy link
Contributor

@Starbuck5Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me. Thanks!

I'm surprised the compiler wouldn't iron this out, but I guess it didn't, if you measured a performance difference.

Copy link
Contributor

@ankith26ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! 👍
Not sure that this would have much difference on performance, but this definitely helps with code clarity so thanks for the PR 😎 🚀

@illumeillume added the PerformanceRelated to the speed or resource usage of the project labelAug 21, 2022
@illumeillume changed the titleremoved pts array in aaline()Cleaned up draw.aaline() code for small speedupAug 21, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@Starbuck5Starbuck5Starbuck5 approved these changes

@ankith26ankith26ankith26 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

drawpygame.drawPerformanceRelated to the speed or resource usage of the project

Projects

None yet

Milestone

2.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@itzpr3d4t0r@Starbuck5@ankith26@illume
[8]ページ先頭
©2009-2025 Movatter.jp