- Notifications
You must be signed in to change notification settings - Fork3.8k
Add SysFont pygame.font.get_fonts() verification test#3266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ankith26 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for contributing to pygame, snek! 🥳 🎈
I just realised, there is a unit test infont_test.py that does something similar to this, so issue#3252 is actually redundant sadly
However that does not mean you need to close this PR, you can make updates to the existing functiontest_match_font_all_exist, as it is missing a test foros.path.isfile
Ah alright, I'll add that when I get home |
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks good to go to me! Thanks for the first time contribution! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍
No description provided.