Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

pyupgrade --py36-plus **/*.py#3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Starbuck5 merged 2 commits intopygame:mainfromcclauss:pyupgrade
Jun 5, 2022
Merged

Conversation

@cclauss
Copy link
Contributor

@cclausscclauss commentedJun 4, 2022•
edited
Loading

Copy link
Contributor

@ankith26ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Heya, thanks for the PR! 🥳 🍰

These are some nice cleanups, I'm kinda surprised myself how we had so much ancient code lying around without these cleanups. 😄

Left a few reviews on some places that could improve with some manual changes.

It would also be handy to get this tool running on our lint CI as long as it's not too heavy

Copy link
Contributor

@dr0iddr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just commented on some things I'm not sure about and added some suggestions to further improve string formatting.

@cclauss
Copy link
ContributorAuthor

Just FYI, flynt would make an additional 119 f-string conversions.

@cclausscclauss requested review fromankith26 anddr0idJune 4, 2022 14:07
@cclauss
Copy link
ContributorAuthor

You folks should consider adding pre-commit so that things likepython3 setup.py format andpython3 setup.py lint are done locally on developer machines beforegit commit completes...https://pre-commit.com

ankith26 reacted with thumbs up emoji

@ankith26
Copy link
Contributor

Just FYI, flynt would make an additional 119 f-string conversions.

Oh, that sounds like a lot. Maybe it would be worth chasing that in a future PR

Yeah, pre-commit sounds useful although I don't have much experience with it myself yet.

cclauss reacted with thumbs up emoji

Copy link
Contributor

@ankith26ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! 🥳

Copy link
Contributor

@Starbuck5Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

3 more reviewers

@Starbuck5Starbuck5Starbuck5 approved these changes

@dr0iddr0iddr0id approved these changes

@ankith26ankith26ankith26 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Code quality/robustnessCode quality and resilience to changesLintersRelated to code linting issues or solutionspython codeThis involves python code

Projects

None yet

Milestone

2.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@cclauss@ankith26@dr0id@Starbuck5
[8]ページ先頭
©2009-2025 Movatter.jp