Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Removed Python 2 nonzero#3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
illume merged 3 commits intopygame:mainfromblankRiot96:blankRiot96/bool-nonzero
May 28, 2022

Conversation

@blankRiot96
Copy link
Contributor

@blankRiot96blankRiot96 commentedMay 25, 2022•
edited
Loading

Following the discussion on Discord,@Starbuck5 had pointed out that__nonzero__ was being used to support both Python 2 and 3. Removed support for Python 2 by only implementing__bool__.

Copy link
Contributor

@ankith26ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice cleanup, thanks for the PR! 👍 🎉

PS: quick search shows that there are a few more uses of__nonzero__ in the pygame codebase, notably sprite still uses it. You could clean that up too if you wish 😉

blankRiot96 reacted with thumbs up emoji
@Starbuck5
Copy link
Contributor

I'm waiting to approve this until after you either fix up the other nonzeros or say you wont fix up the other nonzeros in this PR.

Copy link
Member

@illumeillume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you kindly.

blankRiot96 reacted with thumbs up emoji
@illumeillume merged commitaefeed9 intopygame:mainMay 28, 2022
@illumeillume added the Code quality/robustnessCode quality and resilience to changes labelOct 29, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@illumeillumeillume approved these changes

+1 more reviewer

@ankith26ankith26ankith26 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Code quality/robustnessCode quality and resilience to changespython codeThis involves python code

Projects

None yet

Milestone

2.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@blankRiot96@Starbuck5@illume@ankith26
[8]ページ先頭
©2009-2025 Movatter.jp