Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add test for fullscreen toggle#3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
illume merged 7 commits intopygame:mainfromPurityLake:test-fullscreen-toggle
May 16, 2022
Merged

Add test for fullscreen toggle#3171

illume merged 7 commits intopygame:mainfromPurityLake:test-fullscreen-toggle
May 16, 2022

Conversation

@PurityLake
Copy link
Contributor

@PurityLakePurityLake commentedMay 9, 2022•
edited
Loading

So far I have a visual test for this functionality, making a PR to confirm with people that the test works on other machines.

Should there be an automated test also, or is a visual one ok for this kind of functionality?

Adding this regarding:#1363

Copy link
Contributor

@ankith26ankith26 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the first time PR! 👍 🎉

I can confirm the interactive tests works for me locally on windows.
As discussed on discord, this file also needs a run with theblack code formatter to fix the failing lint checks

@PurityLake
Copy link
ContributorAuthor

@ankith26 made the changes you mentioned

Copy link
Contributor

@ankith26ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks aight now, thanks! 😄 🥳

Copy link
Member

@illumeillume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 🎉 thanks

@illumeillume merged commit0544758 intopygame:mainMay 16, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@illumeillumeillume approved these changes

+1 more reviewer

@ankith26ankith26ankith26 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

displaypygame.displayteststests (module)

Projects

None yet

Milestone

2.1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@PurityLake@illume@ankith26
[8]ページ先頭
©2009-2025 Movatter.jp