NotificationsYou must be signed in to change notification settings
Fork3.8k
Star8.4k

Add _GenericVector to math typestubs, fixes#3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ankith26 merged 8 commits intomainfromankith26-math-typing

Aug 16, 2022

Merged

Add _GenericVector to math typestubs, fixes#3150

ankith26 merged 8 commits intomainfromankith26-math-typing

Aug 16, 2022

Conversation

Copy link

Contributor

ankith26 commentedApr 23, 2022

A followup PR for#3088, after this PR typecheckers should handle return types of some methods of vector subclasses correctly.

While working on this I realised there was a lot of code repetition in theVectorN stubs, so I added a_GenericVector private superclass forVectorN that implements the common methods of both vector objects.

Another idea of mine was to addGenericVector to C code itself, user code should continue to useVectorN but thisGenericVector could exist only to make the C implementation easier and exist as an ABC for vectors maybe? This would be new API and needs more discussion so is something for the future, this PR only affects the typestubs for now

Add _GenericVector to math typestubs, fixes

251735c

andrewhong04 suggested changes

Apr 25, 2022

View reviewed changes

buildconfig/stubs/pygame/math.pyi OutdatedShow resolvedHide resolved

Fix clamp_magnitude_ip typing

16fdb29

Starbuck5 reviewed

May 2, 2022

View reviewed changes

buildconfig/stubs/pygame/math.pyiShow resolvedHide resolved

MyreMylar approved these changes

Jun 14, 2022

View reviewed changes

Copy link

Contributor

MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍 Less duplication

Merge branch 'main' into ankith26-math-typing

4038708

Starbuck5 approved these changes

Aug 10, 2022

View reviewed changes

Copy link

Contributor

Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Typing is far too 🧠 for me right now, but this looks good as far as I can tell.

Thanks for working on this stuff Ankith!

Merge branch 'main' into ankith26-math-typing

183c2d7

Copy link

ContributorAuthor

ankith26 commentedAug 10, 2022•
edited
Loading

Fixed merge conflicts in here.

Was giving a final scroll and I noticed a few more typing issues

Ankith added4 commits

August 10, 2022 11:22

Fix bug: vector rotate functions are not generic

3e62139

Add vector typing for __reduce__, fix init stub

97da61b

Merge branch 'main' into ankith26-math-typing

bf2a978

fix Vector3.update typing to match init signature

b0f8fa1

illume reviewed

Aug 20, 2022

View reviewed changes

Copy link

Member

illume left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Another idea of mine was to add GenericVector to C code itself

Yes, this would be nice.

There is also the Vec4 and Matrix to consider, and a VectorN would be useful (maybe just called Vector). What I'm getting at is perhaps we should plan where these are going. Personally I have need for matrix and larger vectors. Also there is the immutable discussion. We have the immutable discussion here:#2312 and I started an issue for Matrix and Vector4 here:#3412

With regard to type changes... I think we still have some work to do to make them more usable. Especially with testing changes are usable by humans. How do I type my pygame using function to take a ColorLike for example? How do we know type changes aren't breaking user programs? Can we automate more testing of types? Added an issue for this:#3411