- Notifications
You must be signed in to change notification settings - Fork3.8k
Fixed Vector.clamp_magnitude() parameters#3133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍
Should this have a change to the typing? |
Oh, I forgot about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Left two reviews on typehints. Additionally this also needs a round ofpython3 setup.py format
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Ankith <46915066+ankith26@users.noreply.github.com>
Co-authored-by: Ankith <46915066+ankith26@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks for the PR! 👍 🎉
Merging this PR since the lint fail ATM is unrelated to this PR
This PR fixes the parameter order that my
.clamp_magnitude()used. Previously, it was.clamp_magnitude(max, min=0). But now it's.clamp_magnitude(max)and.clamp_magnitude(min, max)to be more consistent with Python'srange().