Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Cleanup old compatibility code in windows sysfont#3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
MyreMylar merged 1 commit intomainfromwindows-sysfont-cleanup
Apr 10, 2022

Conversation

@Starbuck5
Copy link
Contributor

  • got rid of a Windows 95/98/ME compatibility check
  • changed EnvironmentError to OSError, because:

Changed in version 3.3:EnvironmentError,IOError,WindowsError,socket.error,select.error and mmap.error have been merged intoOSError, and the constructor may return a subclass.

(https://docs.python.org/3/library/exceptions.html )

  • got rid of different checks around encoding the font name into a string. I believe these checks are not necessary in python 3, and on my system every font name was already given by winreg as a string.

Copy link
Contributor

@ankith26ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! 👍

Copy link
Contributor

@MyreMylarMyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

Tested locally too (on windows 10) and sysfont seems to work OK still

@illumeillume added the Code quality/robustnessCode quality and resilience to changes labelSep 12, 2022
@illumeillume added the sysfontpygame.sysfont labelOct 29, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@MyreMylarMyreMylarMyreMylar approved these changes

@ankith26ankith26ankith26 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Code quality/robustnessCode quality and resilience to changessysfontpygame.sysfont

Projects

None yet

Milestone

2.1.3

Development

Successfully merging this pull request may close these issues.

5 participants

@Starbuck5@MyreMylar@ankith26@illume
[8]ページ先頭
©2009-2025 Movatter.jp