NotificationsYou must be signed in to change notification settings
Fork3.8k
Star8.4k

Update list of datafiles in generated docs#3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Starbuck5 merged 2 commits intopygame:mainfromwxh06:main

Mar 25, 2022

Merged

Update list of datafiles in generated docs#3073

Starbuck5 merged 2 commits intopygame:mainfromwxh06:main

Mar 25, 2022

Conversation

Copy link

Contributor

wxh06 commentedMar 11, 2022

Added*.txt forLGPL.txt and removed unused*.gif.

add_datafiles(data_files,'pygame/docs/generated',              ['docs/generated',                  ['*.html',# Navigation and help pages'*.txt',# License text'*.js',# For doc search                   ['ref',# pygame reference                       ['*.html',# Reference pages'*.js',# Comments script'*.json']],# Comment data                   ['c_api',# pygame C API                       ['*.html']],                   ['tut',# Tutorials                       ['*.html',                        ['tom',                            ['*.html','*.png']]]],                   ['_static',# Sphinx added support files                        ['*.css','*.png','*.ico','*.js']],                   ['_images',# Sphinx added reST ".. image::" refs                        ['*.jpg','*.png','*.gif']],                   ['_sources',# Used for ref search                        ['*.txt',                         ['ref',                            ['*.txt']]]]]])

wxh06 added2 commits

March 10, 2022 17:01

Add license text (*.txt) in generated docs to datafiles

9457a19

Remove *.gif logos from datafiles in generated docs

36ce90b

Copy link

Contributor

dr0id commentedMar 11, 2022•
edited
Loading

Welcome and thanks for the PR.
Maybe you haven't seen it, but I think its a duplicate of#2977 .

Copy link

Contributor

Grimmys commentedMar 19, 2022

That's not a duplicate for me, there is just a conflict between both.

Mine is for fixing stuff (logos page), this one is just improvement of the files included in the wheels.

Can someone confirm*.gif* is not used?
Then I could cherry-pick this change in my PR and this one could be closed.

Starbuck5 approved these changes

Mar 25, 2022

View reviewed changes

Copy link

Contributor

Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can confirm there aren't any gifs in docs/generated, but there is a txt file.

Thanks for the PR.

ankith26 approved these changes

Mar 25, 2022

View reviewed changes

Copy link

Contributor

ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!
Technically this PR is kinda redundant after the docs PR was merged, which addedLGPL.txt to datafiles, but it's still good because this PR makes it so that all text files are included.
Thanks for the PR 👍 🎉