- Notifications
You must be signed in to change notification settings - Fork3.8k
Regenerate cython files#3032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
well, if it is generated code and all tests pass... can't be so wrong then, can it?
can't really judge all lines, but most make sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
PR tofix#3031
Updated all cython files with a forced regeneration on the latest cython version, in particular, the pypm file which was not updated for a while.
#2916 is the way to go for the future, but since that PR is a draft and might take longer time, this is a good stopgap update for now