Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add missing copy test for Vector3#3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Starbuck5 merged 1 commit intopygame:mainfromJovialKnoll:missing_vector3_test
Jan 26, 2022
Merged

Add missing copy test for Vector3#3000

Starbuck5 merged 1 commit intopygame:mainfromJovialKnoll:missing_vector3_test
Jan 26, 2022

Conversation

@JovialKnoll
Copy link
Contributor

@JovialKnollJovialKnoll commentedJan 22, 2022•
edited
Loading

I noticed there was a copy test for Vector2 but not Vector3, so I added one.

illume, ankith26, and andrewhong04 reacted with thumbs up emojiillume, ankith26, and andrewhong04 reacted with hooray emoji
@illume
Copy link
Member

Thanks.

The test failures seem unrelated to this PR.

Copy link
Contributor

@ankith26ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR! 👍 🎉
As illume also points out, the test failures on CI seem to be unrelated

Copy link
Contributor

@Starbuck5Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. Thanks!

@JovialKnollJovialKnoll deleted the missing_vector3_test branchJanuary 26, 2022 15:06
@illumeillume changed the titleadding missing copy test for Vector3Add missing copy test for Vector3Oct 29, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@Starbuck5Starbuck5Starbuck5 approved these changes

@ankith26ankith26ankith26 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mathpygame.mathteststests (module)

Projects

None yet

Milestone

2.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@JovialKnoll@illume@Starbuck5@ankith26
[8]ページ先頭
©2009-2025 Movatter.jp