Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Python2 to Python3 code modernization#2984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Starbuck5 merged 4 commits intopygame:mainfromandrewhong04:novial-python2-to-python3-examples
Jan 16, 2022
Merged

Python2 to Python3 code modernization#2984

Starbuck5 merged 4 commits intopygame:mainfromandrewhong04:novial-python2-to-python3-examples
Jan 16, 2022

Conversation

@andrewhong04
Copy link
Contributor

Continuation from#2837

ikvk reacted with thumbs up emoji
Copy link
Contributor

@ankith26ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good so far! 🎉
Are you done with the PR, or do you want to add more py2/py3 cleanups in this one? IG some more bits could still do with some modernisation, but that could happen in future PRs too

@andrewhong04
Copy link
ContributorAuthor

andrewhong04 commentedJan 11, 2022•
edited
Loading

Looking good so far! 🎉
Are you done with the PR, or do you want to add more py2/py3 cleanups in this one? IG some more bits could still do with some modernisation, but that could happen in future PRs too

I think this PR is ready to go. I can't find anything else modernize.

@andrewhong04
Copy link
ContributorAuthor

@ankith26 and I had a discussion in Discord and we've decided that it'll be better to remove thefrom pygame.locals import * as well

Copy link
Member

@illumeillume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm :) Thank you kindly.

andrewhong04 reacted with hooray emoji
Copy link
Contributor

@Starbuck5Starbuck5 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Alright, I've read through it all, and tested locally.

Thanks for this!

@ankith26 and I had a discussion in Discord and we've decided that it'll be better to remove the from pygame.locals import * as well

In the examples? That could be a follow up PR.

andrewhong04 reacted with thumbs up emoji
@illumeillume added the Code quality/robustnessCode quality and resilience to changes labelOct 29, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@illumeillumeillume approved these changes

@ankith26ankith26Awaiting requested review from ankith26

+1 more reviewer

@Starbuck5Starbuck5Starbuck5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Code quality/robustnessCode quality and resilience to changesdocsexamplespython codeThis involves python code

Projects

None yet

Milestone

2.1.3

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewhong04@illume@Starbuck5@ankith26
[8]ページ先頭
©2009-2025 Movatter.jp