- Notifications
You must be signed in to change notification settings - Fork3.8k
Snake casify_sdl2.video.Image.flipX and.flipY#2978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
|
@ankith26 Cython generation is dependent on the Cython version, not the Python version. The generated result is compatible with all Cython-supported Python versions. @avaxar I like this change, but I'd like to batch several changes like this into one PR (or one pygame version), to minimize how much of a pain it is to our early adopters. For example, if we're going to rename renderer.present() to renderer.flip() / renderer.update(), as I think we should, we could do that at the same time. |
Maybe there's a way to make this PR merge onto another branch of the unifying PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! Thanks 🎉
We've got to be careful when merging these that the Cython generation isn't overwriting other changes. It should be fine for this one. But other Cython PRs will need to be rebased against main after this merges. |
No description provided.