Typing might want to be something like this instead:https://stackoverflow.com/questions/49427944/typehints-for-sized-iterable-in-python

MightyJosip or Ankith would have a better idea of this than I do.

So I did more digging, and posting some notes of my findings here

1. Objects that provide__getitem__ dunder (examples in pygame includeRect,Color,Vector and possibly more things) are practicallyIterable but they don't actually confirm tocollections.abc.Iterable if they don't provide an__iter__ method as also highlighted by thedocs for the same.
2. This PR does not fix the issue at hand.mypy fails to recognise these pygame objects asIterable because they don't confirm tocollections.abc.Iterable and lack an__iter__ method. The only proper way to fix this is to implement an__iter__ function in C code for these objects, and also typehint it. I know some people are against making these objectsIterable, but the fact is that these are already mostly iterable. By putting an__iter__ method we will be explicitly declaring these as properIterables. We cannot make it not iterate and break lots of compatibility. Doing something likelist(colour_object) orx, y, w, h = rect_obj is fairly commonplace, and all these would break if we changed this

We can still merge this PR because adding__len__ typehint toRect is still a good addition, the iter fix can happen in future PR(s) because it involves changes to C code, tests, docs and types for many objects

I took this "We can still merge this PR" as an approval :)

Thankses.