Thanks Ankith, but yeesh, this diff is something else. This changes 110 lines of a <200 line file.

I don't want to expand environment variables for vidcapture, because that thing is 100% deprecated. In fact, in my last camera PR, illume told me I could remove it, but I kept it, in a role reversal for the ages. Actually, vidcapture could use a deprecation warning (ay, it actually has one already). The biggest problem for me is that I'venever been able to get it working, even though there are third party python 3 wheels (vidcapture is py2) that supposedly work.

Ok, I've read through everything, it looks good.

I'm curious why you refactored all of my individual setup functions into one, though.

Maybe colorspace should have a different error message if it isn't able to be imported. Which it could be, if pygame was built without the _camera module. I don't think it's built on Windows 7.

I'm curious why you refactored all of my individual setup functions into one, though.

Those functions had some unnecessary repetition, and this one function conditional approach seems more elegant to me than having functions kept in a dict and each of those functions having repetition ofglobal statement and_camera import 😄

Maybe colorspace should have a different error message if it isn't able to be imported. Which it could be, if pygame was built without the _camera module. I don't think it's built on Windows 7.

ANotImplementedError is the most pythonic error to be using in a case like this, it was made for a case like this.
Actually, now that you pointed it out and I rechecked with thedocs, this is indeed not the kind of error to be using here. IMHO, we should make it so that the colorspace function is available on all platforms, because it is independent of the camera backend used. Perhaps that bit of_camera should always compile and this function should always be exported, and the other bits could have conditional compilation

I don't want to expand environment variables for vidcapture, because that thing is 100% deprecated. In fact, in my last camera PR, illume told me I could remove it, but I kept it, in a role reversal for the ages.

Ah, ok. Should I revert my change then? Well it does not matter either way IG, this vidcapture changes should remain undocumented anyways

Another thing I wanted to ask, does windows_camera work on win8? Because the code doesint(platform.win32_ver()[0]) > 8 check, should it be>=?

It should work on Windows 8, since every function I used has been around since then, but I’m still not sure. It claims to support it in the docs, so we should try to use it in the code. If it doesn’t work, somebody will open an issue. (Or nobody will care, since not many people use pygame.camera and not many people use Windows 8)

Alrighty :)
I also updated thecolorspace function to emit better errors when not available, although yeah, it should not get triggered in most cases